From 03f091a77fc53ffcd6913419f96cfe5493896161 Mon Sep 17 00:00:00 2001 From: spencerrlongg Date: Thu, 25 Apr 2024 17:17:42 -0500 Subject: [PATCH] ammended note, got real rule in there --- app/Http/Requests/UpdateAssetRequest.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/app/Http/Requests/UpdateAssetRequest.php b/app/Http/Requests/UpdateAssetRequest.php index 60a45da05c..2b6dd9327d 100644 --- a/app/Http/Requests/UpdateAssetRequest.php +++ b/app/Http/Requests/UpdateAssetRequest.php @@ -28,7 +28,7 @@ class UpdateAssetRequest extends ImageUploadRequest $rules = array_merge( parent::rules(), (new Asset)->getRules(), - // this is to overwrite rulesets that include required + // this is to overwrite rulesets that include required, and rewrite unique_undeleted [ 'model_id' => ['integer', 'exists:models,id,deleted_at,NULL', 'not_array'], 'status_id' => ['integer', 'exists:status_labels,id'], @@ -43,12 +43,13 @@ class UpdateAssetRequest extends ImageUploadRequest $rules2 = array_merge( parent::rules(), - // collects rules, 'rejects' required rules + // collects rules, 'rejects' required rules not a fan of this approach, feels inflexible + // what if we decide something _is_ required, etc, it could get complicated and harder to read than the above collect((new Asset)->getRules())->map(function ($rules) { return collect($rules)->reject(function ($rule) { return $rule === 'required'; })->reject(function ($rule) { - return $rule === 'unique_undeleted'; + return $rule === 'unique_undeleted:assets,asset_tag'; })->values()->all(); })->all(), );