mirror of
https://github.com/snipe/snipe-it.git
synced 2024-12-26 06:04:08 -08:00
Implement tests around consumable checkout
This commit is contained in:
parent
3f76d65b95
commit
13c37e708f
|
@ -76,7 +76,6 @@ class ConsumableCheckoutController extends Controller
|
||||||
return redirect()->route('consumables.index')->with('error', trans('admin/consumables/message.checkout.unavailable'));
|
return redirect()->route('consumables.index')->with('error', trans('admin/consumables/message.checkout.unavailable'));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
$admin_user = Auth::user();
|
$admin_user = Auth::user();
|
||||||
$assigned_to = e($request->input('assigned_to'));
|
$assigned_to = e($request->input('assigned_to'));
|
||||||
|
|
||||||
|
|
|
@ -91,4 +91,22 @@ class ConsumableFactory extends Factory
|
||||||
];
|
];
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function withoutItemsRemaining()
|
||||||
|
{
|
||||||
|
return $this->state(function () {
|
||||||
|
return [
|
||||||
|
'qty' => 1,
|
||||||
|
];
|
||||||
|
})->afterCreating(function (Consumable $consumable) {
|
||||||
|
$user = User::factory()->create();
|
||||||
|
|
||||||
|
$consumable->users()->attach($consumable->id, [
|
||||||
|
'consumable_id' => $consumable->id,
|
||||||
|
'user_id' => $user->id,
|
||||||
|
'assigned_to' => $user->id,
|
||||||
|
'note' => '',
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -2,6 +2,11 @@
|
||||||
|
|
||||||
namespace Tests\Feature\Checkouts;
|
namespace Tests\Feature\Checkouts;
|
||||||
|
|
||||||
|
use App\Models\Actionlog;
|
||||||
|
use App\Models\Consumable;
|
||||||
|
use App\Models\User;
|
||||||
|
use App\Notifications\CheckoutConsumableNotification;
|
||||||
|
use Illuminate\Support\Facades\Notification;
|
||||||
use Tests\Support\InteractsWithSettings;
|
use Tests\Support\InteractsWithSettings;
|
||||||
use Tests\TestCase;
|
use Tests\TestCase;
|
||||||
|
|
||||||
|
@ -11,31 +16,81 @@ class ConsumableCheckoutTest extends TestCase
|
||||||
|
|
||||||
public function testCheckingOutConsumableRequiresCorrectPermission()
|
public function testCheckingOutConsumableRequiresCorrectPermission()
|
||||||
{
|
{
|
||||||
$this->markTestIncomplete();
|
$this->actingAs(User::factory()->create())
|
||||||
|
->post(route('consumables.checkout.store', Consumable::factory()->create()))
|
||||||
|
->assertForbidden();
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testValidationWhenCheckingOutConsumable()
|
public function testValidationWhenCheckingOutConsumable()
|
||||||
{
|
{
|
||||||
$this->markTestIncomplete();
|
$this->actingAs(User::factory()->checkoutConsumables()->create())
|
||||||
|
->post(route('consumables.checkout.store', Consumable::factory()->create()), [
|
||||||
|
// missing assigned_to
|
||||||
|
])
|
||||||
|
->assertSessionHas('error');
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testConsumableMustBeAvailableWhenCheckingOut()
|
public function testConsumableMustBeAvailableWhenCheckingOut()
|
||||||
{
|
{
|
||||||
$this->markTestIncomplete();
|
$this->actingAs(User::factory()->checkoutConsumables()->create())
|
||||||
|
->post(route('consumables.checkout.store', Consumable::factory()->withoutItemsRemaining()->create()), [
|
||||||
|
'assigned_to' => User::factory()->create()->id,
|
||||||
|
])
|
||||||
|
->assertSessionHas('error');
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testConsumableCanBeCheckedOut()
|
public function testConsumableCanBeCheckedOut()
|
||||||
{
|
{
|
||||||
$this->markTestIncomplete();
|
$consumable = Consumable::factory()->create();
|
||||||
|
$user = User::factory()->create();
|
||||||
|
|
||||||
|
$this->actingAs(User::factory()->checkoutConsumables()->create())
|
||||||
|
->post(route('consumables.checkout.store', $consumable), [
|
||||||
|
'assigned_to' => $user->id,
|
||||||
|
]);
|
||||||
|
|
||||||
|
$this->assertTrue($user->consumables->contains($consumable));
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testUserSentNotificationUponCheckout()
|
public function testUserSentNotificationUponCheckout()
|
||||||
{
|
{
|
||||||
$this->markTestIncomplete();
|
Notification::fake();
|
||||||
|
|
||||||
|
$consumable = Consumable::factory()->create();
|
||||||
|
$user = User::factory()->create();
|
||||||
|
|
||||||
|
$this->actingAs(User::factory()->checkoutConsumables()->create())
|
||||||
|
->post(route('consumables.checkout.store', $consumable), [
|
||||||
|
'assigned_to' => $user->id,
|
||||||
|
]);
|
||||||
|
|
||||||
|
Notification::assertSentTo($user, CheckoutConsumableNotification::class);
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testActionLogCreatedUponCheckout()
|
public function testActionLogCreatedUponCheckout()
|
||||||
{
|
{
|
||||||
$this->markTestIncomplete();
|
$consumable = Consumable::factory()->create();
|
||||||
|
$actor = User::factory()->checkoutConsumables()->create();
|
||||||
|
$user = User::factory()->create();
|
||||||
|
|
||||||
|
$this->actingAs($actor)
|
||||||
|
->post(route('consumables.checkout.store', $consumable), [
|
||||||
|
'assigned_to' => $user->id,
|
||||||
|
'note' => 'oh hi there',
|
||||||
|
]);
|
||||||
|
|
||||||
|
$this->assertEquals(
|
||||||
|
1,
|
||||||
|
Actionlog::where([
|
||||||
|
'action_type' => 'checkout',
|
||||||
|
'target_id' => $user->id,
|
||||||
|
'target_type' => User::class,
|
||||||
|
'item_id' => $consumable->id,
|
||||||
|
'item_type' => Consumable::class,
|
||||||
|
'user_id' => $actor->id,
|
||||||
|
'note' => 'oh hi there',
|
||||||
|
])->count(),
|
||||||
|
'Log entry either does not exist or there are more than expected'
|
||||||
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue