diff --git a/app/Http/Controllers/Api/ConsumablesController.php b/app/Http/Controllers/Api/ConsumablesController.php index 1c31ec0ea2..d6e3350ddc 100644 --- a/app/Http/Controllers/Api/ConsumablesController.php +++ b/app/Http/Controllers/Api/ConsumablesController.php @@ -2,6 +2,7 @@ namespace App\Http\Controllers\Api; +use App\Events\CheckoutableCheckedOut; use App\Helpers\Helper; use App\Http\Controllers\Controller; use App\Http\Transformers\ConsumablesTransformer; @@ -11,6 +12,7 @@ use App\Models\Consumable; use App\Models\User; use Illuminate\Http\Request; use App\Http\Requests\ImageUploadRequest; +use Illuminate\Support\Facades\Auth; class ConsumablesController extends Controller { @@ -290,17 +292,9 @@ class ConsumablesController extends Controller ] ); - // Log checkout event - $logaction = $consumable->logCheckout($request->input('note'), $user); - $data['log_id'] = $logaction->id; - $data['eula'] = $consumable->getEula(); - $data['first_name'] = $user->first_name; - $data['item_name'] = $consumable->name; - $data['checkout_date'] = $logaction->created_at; - $data['note'] = $logaction->note; - $data['require_acceptance'] = $consumable->requireAcceptance(); + event(new CheckoutableCheckedOut($consumable, $user, Auth::user(), $request->input('note'))); - return response()->json(Helper::formatStandardApiResponse('success', null, trans('admin/consumables/message.checkout.success'))); + return response()->json(Helper::formatStandardApiResponse('success', null, trans('admin/consumables/message.checkout.success'))); } diff --git a/app/Http/Controllers/Consumables/ConsumableCheckoutController.php b/app/Http/Controllers/Consumables/ConsumableCheckoutController.php index 0cac973415..f7a297aeee 100644 --- a/app/Http/Controllers/Consumables/ConsumableCheckoutController.php +++ b/app/Http/Controllers/Consumables/ConsumableCheckoutController.php @@ -76,7 +76,6 @@ class ConsumableCheckoutController extends Controller return redirect()->route('consumables.index')->with('error', trans('admin/consumables/message.checkout.unavailable')); } - $admin_user = Auth::user(); $assigned_to = e($request->input('assigned_to')); diff --git a/database/factories/ConsumableFactory.php b/database/factories/ConsumableFactory.php index 18a116418b..d9aec36afa 100644 --- a/database/factories/ConsumableFactory.php +++ b/database/factories/ConsumableFactory.php @@ -91,4 +91,29 @@ class ConsumableFactory extends Factory ]; }); } + + public function withoutItemsRemaining() + { + return $this->state(function () { + return [ + 'qty' => 1, + ]; + })->afterCreating(function (Consumable $consumable) { + $user = User::factory()->create(); + + $consumable->users()->attach($consumable->id, [ + 'consumable_id' => $consumable->id, + 'user_id' => $user->id, + 'assigned_to' => $user->id, + 'note' => '', + ]); + }); + } + + public function requiringAcceptance() + { + return $this->afterCreating(function (Consumable $consumable) { + $consumable->category->update(['require_acceptance' => 1]); + }); + } } diff --git a/tests/Feature/Api/Accessories/AccessoryCheckoutTest.php b/tests/Feature/Api/Accessories/AccessoryCheckoutTest.php index f4f49f0dbc..d65a3ad613 100644 --- a/tests/Feature/Api/Accessories/AccessoryCheckoutTest.php +++ b/tests/Feature/Api/Accessories/AccessoryCheckoutTest.php @@ -21,7 +21,7 @@ class AccessoryCheckoutTest extends TestCase ->assertForbidden(); } - public function testValidation() + public function testValidationWhenCheckingOutAccessory() { $this->actingAsForApi(User::factory()->checkoutAccessories()->create()) ->postJson(route('api.accessories.checkout', Accessory::factory()->create()), [ diff --git a/tests/Feature/Api/Consumables/ConsumableCheckoutTest.php b/tests/Feature/Api/Consumables/ConsumableCheckoutTest.php new file mode 100644 index 0000000000..103be96ac2 --- /dev/null +++ b/tests/Feature/Api/Consumables/ConsumableCheckoutTest.php @@ -0,0 +1,96 @@ +actingAsForApi(User::factory()->create()) + ->postJson(route('api.consumables.checkout', Consumable::factory()->create())) + ->assertForbidden(); + } + + public function testValidationWhenCheckingOutConsumable() + { + $this->actingAsForApi(User::factory()->checkoutConsumables()->create()) + ->postJson(route('api.consumables.checkout', Consumable::factory()->create()), [ + // missing assigned_to + ]) + ->assertStatusMessageIs('error'); + } + + public function testConsumableMustBeAvailableWhenCheckingOut() + { + $this->actingAsForApi(User::factory()->checkoutConsumables()->create()) + ->postJson(route('api.consumables.checkout', Consumable::factory()->withoutItemsRemaining()->create()), [ + 'assigned_to' => User::factory()->create()->id, + ]) + ->assertStatusMessageIs('error'); + } + + public function testConsumableCanBeCheckedOut() + { + $consumable = Consumable::factory()->create(); + $user = User::factory()->create(); + + $this->actingAsForApi(User::factory()->checkoutConsumables()->create()) + ->postJson(route('api.consumables.checkout', $consumable), [ + 'assigned_to' => $user->id, + ]); + + $this->assertTrue($user->consumables->contains($consumable)); + } + + public function testUserSentNotificationUponCheckout() + { + Notification::fake(); + + $consumable = Consumable::factory()->requiringAcceptance()->create(); + + $user = User::factory()->create(); + + $this->actingAsForApi(User::factory()->checkoutConsumables()->create()) + ->postJson(route('api.consumables.checkout', $consumable), [ + 'assigned_to' => $user->id, + ]); + + Notification::assertSentTo($user, CheckoutConsumableNotification::class); + } + + public function testActionLogCreatedUponCheckout() + {$consumable = Consumable::factory()->create(); + $actor = User::factory()->checkoutConsumables()->create(); + $user = User::factory()->create(); + + $this->actingAsForApi($actor) + ->postJson(route('api.consumables.checkout', $consumable), [ + 'assigned_to' => $user->id, + 'note' => 'oh hi there', + ]); + + $this->assertEquals( + 1, + Actionlog::where([ + 'action_type' => 'checkout', + 'target_id' => $user->id, + 'target_type' => User::class, + 'item_id' => $consumable->id, + 'item_type' => Consumable::class, + 'user_id' => $actor->id, + 'note' => 'oh hi there', + ])->count(), + 'Log entry either does not exist or there are more than expected' + ); + } +} diff --git a/tests/Feature/Checkouts/AccessoryCheckoutTest.php b/tests/Feature/Checkouts/AccessoryCheckoutTest.php index 74269bfbb9..cbe9801cc0 100644 --- a/tests/Feature/Checkouts/AccessoryCheckoutTest.php +++ b/tests/Feature/Checkouts/AccessoryCheckoutTest.php @@ -21,7 +21,7 @@ class AccessoryCheckoutTest extends TestCase ->assertForbidden(); } - public function testValidation() + public function testValidationWhenCheckingOutAccessory() { $this->actingAs(User::factory()->checkoutAccessories()->create()) ->post(route('accessories.checkout.store', Accessory::factory()->create()), [ diff --git a/tests/Feature/Checkouts/ConsumableCheckoutTest.php b/tests/Feature/Checkouts/ConsumableCheckoutTest.php new file mode 100644 index 0000000000..5785d0572b --- /dev/null +++ b/tests/Feature/Checkouts/ConsumableCheckoutTest.php @@ -0,0 +1,96 @@ +actingAs(User::factory()->create()) + ->post(route('consumables.checkout.store', Consumable::factory()->create())) + ->assertForbidden(); + } + + public function testValidationWhenCheckingOutConsumable() + { + $this->actingAs(User::factory()->checkoutConsumables()->create()) + ->post(route('consumables.checkout.store', Consumable::factory()->create()), [ + // missing assigned_to + ]) + ->assertSessionHas('error'); + } + + public function testConsumableMustBeAvailableWhenCheckingOut() + { + $this->actingAs(User::factory()->checkoutConsumables()->create()) + ->post(route('consumables.checkout.store', Consumable::factory()->withoutItemsRemaining()->create()), [ + 'assigned_to' => User::factory()->create()->id, + ]) + ->assertSessionHas('error'); + } + + public function testConsumableCanBeCheckedOut() + { + $consumable = Consumable::factory()->create(); + $user = User::factory()->create(); + + $this->actingAs(User::factory()->checkoutConsumables()->create()) + ->post(route('consumables.checkout.store', $consumable), [ + 'assigned_to' => $user->id, + ]); + + $this->assertTrue($user->consumables->contains($consumable)); + } + + public function testUserSentNotificationUponCheckout() + { + Notification::fake(); + + $consumable = Consumable::factory()->create(); + $user = User::factory()->create(); + + $this->actingAs(User::factory()->checkoutConsumables()->create()) + ->post(route('consumables.checkout.store', $consumable), [ + 'assigned_to' => $user->id, + ]); + + Notification::assertSentTo($user, CheckoutConsumableNotification::class); + } + + public function testActionLogCreatedUponCheckout() + { + $consumable = Consumable::factory()->create(); + $actor = User::factory()->checkoutConsumables()->create(); + $user = User::factory()->create(); + + $this->actingAs($actor) + ->post(route('consumables.checkout.store', $consumable), [ + 'assigned_to' => $user->id, + 'note' => 'oh hi there', + ]); + + $this->assertEquals( + 1, + Actionlog::where([ + 'action_type' => 'checkout', + 'target_id' => $user->id, + 'target_type' => User::class, + 'item_id' => $consumable->id, + 'item_type' => Consumable::class, + 'user_id' => $actor->id, + 'note' => 'oh hi there', + ])->count(), + 'Log entry either does not exist or there are more than expected' + ); + } +}