mirror of
https://github.com/snipe/snipe-it.git
synced 2025-03-05 20:52:15 -08:00
Scaffold test before removing scopeCompanyables call from DepartmentsController
This commit is contained in:
parent
8e6e525b47
commit
27d4d107bb
|
@ -271,6 +271,15 @@ class UserFactory extends Factory
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function viewDepartments()
|
||||||
|
{
|
||||||
|
return $this->state(function () {
|
||||||
|
return [
|
||||||
|
'permissions' => '{"departments.view":"1"}',
|
||||||
|
];
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
public function viewLicenses()
|
public function viewLicenses()
|
||||||
{
|
{
|
||||||
return $this->state(function () {
|
return $this->state(function () {
|
||||||
|
|
74
tests/Feature/Api/Departments/DepartmentsIndexTest.php
Normal file
74
tests/Feature/Api/Departments/DepartmentsIndexTest.php
Normal file
|
@ -0,0 +1,74 @@
|
||||||
|
<?php
|
||||||
|
|
||||||
|
namespace Tests\Feature\Api\Departments;
|
||||||
|
|
||||||
|
use App\Models\Company;
|
||||||
|
use App\Models\Department;
|
||||||
|
use App\Models\User;
|
||||||
|
use Illuminate\Testing\TestResponse;
|
||||||
|
use Laravel\Passport\Passport;
|
||||||
|
use Tests\Support\InteractsWithSettings;
|
||||||
|
use Tests\TestCase;
|
||||||
|
|
||||||
|
class DepartmentsIndexTest extends TestCase
|
||||||
|
{
|
||||||
|
use InteractsWithSettings;
|
||||||
|
|
||||||
|
public function testDepartmentsIndexAdheresToCompanyScoping()
|
||||||
|
{
|
||||||
|
$this->markTestIncomplete();
|
||||||
|
|
||||||
|
[$companyA, $companyB] = Company::factory()->count(2)->create();
|
||||||
|
|
||||||
|
$departmentA = Department::factory()->for($companyA)->create();
|
||||||
|
$departmentB = Department::factory()->for($companyB)->create();
|
||||||
|
|
||||||
|
$superUser = $companyA->users()->save(User::factory()->superuser()->make());
|
||||||
|
$userInCompanyA = $companyA->users()->save(User::factory()->viewDepartments()->make());
|
||||||
|
$userInCompanyB = $companyB->users()->save(User::factory()->viewDepartments()->make());
|
||||||
|
|
||||||
|
$this->settings->disableMultipleFullCompanySupport();
|
||||||
|
|
||||||
|
Passport::actingAs($superUser);
|
||||||
|
$response = $this->getJson(route('api.departments.index'));
|
||||||
|
$this->assertResponseContains($response, $departmentA);
|
||||||
|
$this->assertResponseContains($response, $departmentB);
|
||||||
|
|
||||||
|
Passport::actingAs($userInCompanyA);
|
||||||
|
$response = $this->getJson(route('api.departments.index'));
|
||||||
|
$this->assertResponseContains($response, $departmentA);
|
||||||
|
$this->assertResponseContains($response, $departmentB);
|
||||||
|
|
||||||
|
Passport::actingAs($userInCompanyB);
|
||||||
|
$response = $this->getJson(route('api.departments.index'));
|
||||||
|
$this->assertResponseContains($response, $departmentA);
|
||||||
|
$this->assertResponseContains($response, $departmentB);
|
||||||
|
|
||||||
|
$this->settings->enableMultipleFullCompanySupport();
|
||||||
|
|
||||||
|
Passport::actingAs($superUser);
|
||||||
|
$response = $this->getJson(route('api.departments.index'));
|
||||||
|
$this->assertResponseContains($response, $departmentA);
|
||||||
|
$this->assertResponseContains($response, $departmentB);
|
||||||
|
|
||||||
|
Passport::actingAs($userInCompanyA);
|
||||||
|
$response = $this->getJson(route('api.departments.index'));
|
||||||
|
$this->assertResponseContains($response, $departmentA);
|
||||||
|
$this->assertResponseDoesNotContain($response, $departmentB);
|
||||||
|
|
||||||
|
Passport::actingAs($userInCompanyB);
|
||||||
|
$response = $this->getJson(route('api.departments.index'));
|
||||||
|
$this->assertResponseDoesNotContain($response, $departmentA);
|
||||||
|
$this->assertResponseContains($response, $departmentB);
|
||||||
|
}
|
||||||
|
|
||||||
|
private function assertResponseContains(TestResponse $response, Department $department)
|
||||||
|
{
|
||||||
|
$this->assertTrue(collect($response['rows'])->pluck('name')->contains($department->name));
|
||||||
|
}
|
||||||
|
|
||||||
|
private function assertResponseDoesNotContain(TestResponse $response, Department $department)
|
||||||
|
{
|
||||||
|
$this->assertFalse(collect($response['rows'])->pluck('name')->contains($department->name));
|
||||||
|
}
|
||||||
|
}
|
Loading…
Reference in a new issue