DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2024-12-25 05:34:06 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix memory-hog query in AssetCountForSidebar middleware

Browse source 
https://github.com/snipe/snipe-it/pull/14702/files introduced a bug
where instead of doing a quick `select count(*)` of assets, it did a `select *` of
assets, moving the count from the database to the PHP process.

This caused OOM issues in memory-constrained environments with lots of
assets, and also presented a speed issue even when memory limited were
increased.

Additionally, given this populates the sidebar, this was likely an issue
on every page load that included the sidebar.

The fix is simply removing the `all()->`, ending up with Asset::count(),
which yields the desired `select count(*)` DB query.
This commit is contained in:
Jeremy Price 2024-05-10 12:54:40 -07:00
parent 46779ca865
commit 2adc4ffa96
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/Http/Middleware/AssetCountForSidebar.php
View file

@ -35,7 +35,7 @@ class AssetCountForSidebar
} }
try { try {
$total_assets = Asset::all()->count(); $total_assets = Asset::count();
if ($settings->show_archived_in_list != '1') { if ($settings->show_archived_in_list != '1') {
$total_assets -= Asset::Archived()->count(); $total_assets -= Asset::Archived()->count();
} }