DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2024-09-20 07:47:41 -07:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Improve comments and remove unused imports

Browse source
This commit is contained in:
Marcus Moore 2023-04-05 12:39:41 -07:00
parent 3cc3662992
commit 3054d633b0
No known key found for this signature in database
1 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/Listeners/CheckoutableListener.php
View file

@ -9,15 +9,12 @@ use App\Models\Consumable;
use App\Models\LicenseSeat; use App\Models\LicenseSeat;
use App\Models\Recipients\AdminRecipient; use App\Models\Recipients\AdminRecipient;
use App\Models\Setting; use App\Models\Setting;
use App\Models\User;
use App\Notifications\CheckinAccessoryNotification; use App\Notifications\CheckinAccessoryNotification;
use App\Notifications\CheckinAssetNotification; use App\Notifications\CheckinAssetNotification;
use App\Notifications\CheckinLicenseNotification;
use App\Notifications\CheckinLicenseSeatNotification; use App\Notifications\CheckinLicenseSeatNotification;
use App\Notifications\CheckoutAccessoryNotification; use App\Notifications\CheckoutAccessoryNotification;
use App\Notifications\CheckoutAssetNotification; use App\Notifications\CheckoutAssetNotification;
use App\Notifications\CheckoutConsumableNotification; use App\Notifications\CheckoutConsumableNotification;
use App\Notifications\CheckoutLicenseNotification;
use App\Notifications\CheckoutLicenseSeatNotification; use App\Notifications\CheckoutLicenseSeatNotification;
use Illuminate\Support\Facades\Notification; use Illuminate\Support\Facades\Notification;
use Exception; use Exception;
@ -26,16 +23,12 @@ use Log;
class CheckoutableListener class CheckoutableListener
{ {
/** /**
* Notify the user about the checked out checkoutable and add a record to the * Notify the user and post to webhook about the checked out checkoutable and add a record to the
* checkout_requests table. * checkout_requests table.
*/ */
public function onCheckedOut($event) public function onCheckedOut($event)
{ {
// Send an anonymous webhook notification if setting enabled
// @todo: update docblock
// @todo: comment...we send this anonymously so that webhook notification still
// @todo: get sent for models that don't have email addresses associated...
if ($this->shouldSendWebhookNotification()) { if ($this->shouldSendWebhookNotification()) {
Notification::route('slack', Setting::getSettings()->webhook_endpoint) Notification::route('slack', Setting::getSettings()->webhook_endpoint)
->notify($this->getCheckoutNotification($event)); ->notify($this->getCheckoutNotification($event));
@ -65,16 +58,13 @@ class CheckoutableListener
} }
/** /**
* Notify the user about the checked in checkoutable * Notify the user and post to webhook about the checked in checkoutable
*/ */
public function onCheckedIn($event) public function onCheckedIn($event)
{ {
\Log::debug('onCheckedIn in the Checkoutable listener fired'); \Log::debug('onCheckedIn in the Checkoutable listener fired');
// @todo: update docblock // Send an anonymous webhook notification if setting enabled
// @todo: comment...we send this anonymously so that webhook notification still
// @todo: get sent for models that don't have email addresses associated...
if ($this->shouldSendWebhookNotification()) { if ($this->shouldSendWebhookNotification()) {
Notification::route('slack', Setting::getSettings()->webhook_endpoint) Notification::route('slack', Setting::getSettings()->webhook_endpoint)
->notify($this->getCheckinNotification($event)); ->notify($this->getCheckinNotification($event));