DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-03-05 20:52:15 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fixes test to check if checked in licenses is unavailable

Browse source
This commit is contained in:
Godfrey M 2025-01-16 09:46:03 -08:00
parent 7a23372489
commit 344b4e7d60
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/Http/Controllers/Licenses/LicenseCheckinController.php
View file

@ -95,9 +95,10 @@ class LicenseCheckinController extends Controller
$licenseSeat->assigned_to = null; $licenseSeat->assigned_to = null;
$licenseSeat->asset_id = null; $licenseSeat->asset_id = null;
$licenseSeat->notes = $request->input('notes'); $licenseSeat->notes = $request->input('notes');
if (! $license->reassignable) { if (! $licenseSeat->license->reassignable) {
$licenseSeat->unavailable = 1; $licenseSeat->unavailable = 1;
$licenseSeat->notes .= "\n" . trans('admin/licenses/message.checkin.not_reassignable') . '.'; $licenseSeat->notes .= "\n" . trans('admin/licenses/message.checkin.not_reassignable') . '.';
} }
session()->put(['redirect_option' => $request->get('redirect_option')]); session()->put(['redirect_option' => $request->get('redirect_option')]);

1
database/factories/LicenseSeatFactory.php
View file

@ -14,6 +14,7 @@ class LicenseSeatFactory extends Factory
{ {
return [ return [
'license_id' => License::factory(), 'license_id' => License::factory(),
'unavailable' => 0,
]; ];
} }

12
tests/Feature/Checkins/Ui/LicenseCheckinTest.php
View file

@ -20,7 +20,7 @@ class LicenseCheckinTest extends TestCase
->assertForbidden(); ->assertForbidden();
} }
public function testCannotCheckinNonReassignableLicense() public function testNonReassignableLicenseSeatIsUnavailable()
{ {
$licenseSeat = LicenseSeat::factory() $licenseSeat = LicenseSeat::factory()
->notReassignable() ->notReassignable()
@ -28,13 +28,11 @@ class LicenseCheckinTest extends TestCase
->create(); ->create();
$this->actingAs(User::factory()->checkoutLicenses()->create()) $this->actingAs(User::factory()->checkoutLicenses()->create())
->post(route('licenses.checkin.save', $licenseSeat), [ ->post(route('licenses.checkin.save', $licenseSeat));
'notes' => 'my note',
'redirect_option' => 'index',
])
->assertSessionHas('error', trans('admin/licenses/message.checkin.not_reassignable') . '.');
$this->assertNotNull($licenseSeat->fresh()->assigned_to); $licenseSeat->refresh();
$this->assertEquals(1, $licenseSeat->unavailable);
} }
public function testCannotCheckinLicenseThatIsNotAssigned() public function testCannotCheckinLicenseThatIsNotAssigned()