DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-02-21 03:15:45 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

catch custom fields that are arrays

Browse source
This commit is contained in:
spencerrlongg 2023-10-17 19:03:58 -05:00
parent 74ed32903f
commit 388e4c10c4
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/Http/Controllers/Api/AssetsController.php
View file

@ -530,7 +530,6 @@ class AssetsController extends Controller
* @author [A. Gianotto] [<snipe@snipe.net>] * @author [A. Gianotto] [<snipe@snipe.net>]
* @param \App\Http\Requests\ImageUploadRequest $request * @param \App\Http\Requests\ImageUploadRequest $request
* @since [v4.0] * @since [v4.0]
* @return JsonResponse
*/ */
public function store(ImageUploadRequest $request) public function store(ImageUploadRequest $request)
{ {
@ -579,6 +578,10 @@ class AssetsController extends Controller
if (($model) && ($model->fieldset)) { if (($model) && ($model->fieldset)) {
foreach ($model->fieldset->fields as $field) { foreach ($model->fieldset->fields as $field) {
//reduce "array to string conversion" exceptions - ideally we'd handle this in a form request, but this works for now
if(is_array($request->input($field->db_column, null))) {
return response()->json(Helper::formatStandardApiResponse('error', null, 'This custom field can not be an array', 200));
}
// Set the field value based on what was sent in the request // Set the field value based on what was sent in the request
$field_val = $request->input($field->db_column, null); $field_val = $request->input($field->db_column, null);

4
app/Models/Asset.php
View file

@ -220,10 +220,6 @@ class Asset extends Depreciable
} }
} }
if (!is_array($params)){
return false;
}
return parent::save($params); return parent::save($params);
} }