Notes and style cleanups

This commit is contained in:
Daniel Meltzer 2020-04-28 11:44:17 -04:00
parent 9520ccae47
commit 3e7fbb02b7
No known key found for this signature in database
GPG key ID: 91C5C7B09A5B1CA0
2 changed files with 2 additions and 2 deletions

View file

@ -22,7 +22,6 @@ class AssetsCest
public function failsEmptyValidation(FunctionalTester $I)
{
$I->wantTo("Test Validation Fails with blank elements");
$I->amOnPage(route('hardware.create'));
// Settings factory can enable auto prefixes, which generate a random asset id. Lets clear it out for the sake of this test.
@ -54,7 +53,7 @@ class AssetsCest
'purchase_date' => '2016-01-01',
'requestable' => $asset->requestable,
'rtd_location_id' => $asset->rtd_location_id,
'serials[1]' => $asset->serial,
'serials[1]' => $asset->serial,
'status_id' => $asset->status_id,
'supplier_id' => $asset->supplier_id,
'warranty_months' => $asset->warranty_months,

View file

@ -38,6 +38,7 @@ class CategoryTest extends BaseTest
$this->assertCount(5, $category->models);
$models->each(function($model) {
// This is intentionally run twice to generate the ten imagined assets, done this way to keep it in sync with createValidAsset rather than using the factory directly.
$this->createValidAsset(['model_id' => $model->id]);
$this->createValidAsset(['model_id' => $model->id]);
});