diff --git a/.all-contributorsrc b/.all-contributorsrc index a373eb207c..11f05869c7 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -2736,7 +2736,7 @@ "avatar_url": "https://avatars.githubusercontent.com/u/111710123?v=4", "profile": "https://github.com/Vautia", "contributions": [ - "security" + "code" ] }, { @@ -2756,6 +2756,15 @@ "contributions": [ "code" ] + }, + { + "login": "nh314", + "name": "Phan Nguyen", + "avatar_url": "https://avatars.githubusercontent.com/u/6006620?v=4", + "profile": "https://github.com/nh314", + "contributions": [ + "code" + ] } ] } diff --git a/.github/workflows/SA-codeql.yml b/.github/workflows/SA-codeql.yml index a98bf955f1..d76c898e1c 100644 --- a/.github/workflows/SA-codeql.yml +++ b/.github/workflows/SA-codeql.yml @@ -26,7 +26,7 @@ jobs: language: [ 'javascript' ] steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3.1.0 # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL diff --git a/.github/workflows/codacy-analysis.yml b/.github/workflows/codacy-analysis.yml index ffc488c906..819829f5af 100644 --- a/.github/workflows/codacy-analysis.yml +++ b/.github/workflows/codacy-analysis.yml @@ -32,7 +32,7 @@ jobs: steps: # Checkout the repository to the GitHub Actions runner - name: Checkout code - uses: actions/checkout@v2 + uses: actions/checkout@v3.1.0 # Execute Codacy Analysis CLI and generate a SARIF output with the security issues identified during the analysis - name: Run Codacy Analysis CLI diff --git a/.github/workflows/docker-alpine.yml b/.github/workflows/docker-alpine.yml index aad3a77cc5..1eafe33cf6 100644 --- a/.github/workflows/docker-alpine.yml +++ b/.github/workflows/docker-alpine.yml @@ -41,7 +41,7 @@ jobs: steps: # https://github.com/actions/checkout - name: Checkout codebase - uses: actions/checkout@v2 + uses: actions/checkout@v3.1.0 # https://github.com/docker/setup-buildx-action - name: Setup Docker Buildx diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 19c6d25886..f166a29f89 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -41,7 +41,7 @@ jobs: steps: # https://github.com/actions/checkout - name: Checkout codebase - uses: actions/checkout@v2 + uses: actions/checkout@v3.1.0 # https://github.com/docker/setup-buildx-action - name: Setup Docker Buildx diff --git a/app/Http/Controllers/Api/LicenseSeatsController.php b/app/Http/Controllers/Api/LicenseSeatsController.php index 4d0fe09949..759f11e956 100644 --- a/app/Http/Controllers/Api/LicenseSeatsController.php +++ b/app/Http/Controllers/Api/LicenseSeatsController.php @@ -39,7 +39,7 @@ class LicenseSeatsController extends Controller } $total = $seats->count(); - $offset = (($seats) && (request('offset') > $total)) ? 0 : request('offset', 0); + $offset = (($seats) && (request('offset') >= $total)) ? 0 : request('offset', 0); $limit = request('limit', 50); $seats = $seats->skip($offset)->take($limit)->get(); diff --git a/app/Models/Loggable.php b/app/Models/Loggable.php index cf5eabc67b..53ff279a09 100644 --- a/app/Models/Loggable.php +++ b/app/Models/Loggable.php @@ -189,7 +189,7 @@ trait Loggable $params = [ 'item' => $log->item, 'filename' => $log->filename, - 'admin' => $log->user, + 'admin' => $log->admin, 'location' => ($location) ? $location->name : '', 'note' => $note, ]; diff --git a/config/version.php b/config/version.php index 9f8b9a6988..8604157fe3 100644 --- a/config/version.php +++ b/config/version.php @@ -6,5 +6,5 @@ return array ( 'prerelease_version' => '', 'hash_version' => 'g61fa0bda4', 'full_hash' => 'v6.0.11-145-g61fa0bda4', - 'branch' => 'master', + 'branch' => 'develop', ); \ No newline at end of file diff --git a/resources/views/licenses/edit.blade.php b/resources/views/licenses/edit.blade.php index b8b0e13a69..0936f8b2b7 100755 --- a/resources/views/licenses/edit.blade.php +++ b/resources/views/licenses/edit.blade.php @@ -34,7 +34,7 @@ @include ('partials.forms.edit.company-select', ['translated_name' => trans('general.company'), 'fieldname' => 'company_id']) -@include ('partials.forms.edit.manufacturer-select', ['translated_name' => trans('general.manufacturer'), 'fieldname' => 'manufacturer_id', 'required' => 'true']) +@include ('partials.forms.edit.manufacturer-select', ['translated_name' => trans('general.manufacturer'), 'fieldname' => 'manufacturer_id',])