DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2024-12-26 22:19:41 -08:00
Code Issues Actions 11 Packages Projects Releases Wiki Activity

Give a better response to listing no files on an asset

Browse source 
HTTP500 was never a good choice. Now it sends back an empty array
This commit is contained in:
Scarzy 2024-05-26 19:01:24 +01:00
parent b9d56a8ecc
commit 45329912e6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/Http/Controllers/Api/AssetFilesController.php
View file

@ -110,8 +110,8 @@ class AssetFilesController extends Controller
return response()->json(Helper::formatStandardApiResponse('success', $files, trans('admin/hardware/message.upload.success'))); return response()->json(Helper::formatStandardApiResponse('success', $files, trans('admin/hardware/message.upload.success')));
} }
// There are no files. This possibly isn't the best response for this, but it does get the point across // There are no files.
return response()->json(Helper::formatStandardApiResponse('error', null, trans('admin/hardware/message.download.no_match', ['id' => $fileId])), 500); return response()->json(Helper::formatStandardApiResponse('success', array(), trans('admin/hardware/message.upload.success')));
} }
// //