From 505d601488c02224adb775358c69751e9428f44f Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Thu, 30 Nov 2023 17:07:39 -0800 Subject: [PATCH] Implement restoring date ranges --- resources/views/reports/custom.blade.php | 20 ++++++++++---------- tests/Unit/SavedReportTest.php | 12 ++++++++++++ 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/resources/views/reports/custom.blade.php b/resources/views/reports/custom.blade.php index 6aa91e32b2..e85271f8cd 100644 --- a/resources/views/reports/custom.blade.php +++ b/resources/views/reports/custom.blade.php @@ -276,9 +276,9 @@
- + to - +
@@ -286,9 +286,9 @@
- + to - +
@@ -296,9 +296,9 @@
- + to - +
@@ -306,9 +306,9 @@
- + to - +
@@ -316,9 +316,9 @@
- + to - +
diff --git a/tests/Unit/SavedReportTest.php b/tests/Unit/SavedReportTest.php index b5361cfdb7..2947667081 100644 --- a/tests/Unit/SavedReportTest.php +++ b/tests/Unit/SavedReportTest.php @@ -83,4 +83,16 @@ class SavedReportTest extends TestCase { $this->markTestIncomplete(); } + + public function testDateRangesAreNotStored() + { + $this->markTestIncomplete(); + + // This might not be a test we implement, but it's a place to ask a question: + // Should we be saving and restoring date ranges? + // A use-case I can see is running a report at the end of the month for the date ranges for that month. + // Maybe it's better to leave those off so users are gently prompted to enter the ranges for each run? + // Another option would be to have checkbox that asks the user if they would like to save the dates? + // I'm not sure how helpful that is, and it would probably be a future feature if implemented. + } }