mirror of
https://github.com/snipe/snipe-it.git
synced 2025-03-05 20:52:15 -08:00
Add authorization to saving saved reports route
This commit is contained in:
parent
c3845f4393
commit
52028ddef2
|
@ -8,6 +8,8 @@ class SavedReportsController extends Controller
|
||||||
{
|
{
|
||||||
public function store(Request $request)
|
public function store(Request $request)
|
||||||
{
|
{
|
||||||
|
$this->authorize('reports.view');
|
||||||
|
|
||||||
$report = $request->user()->savedReports()->create([
|
$report = $request->user()->savedReports()->create([
|
||||||
'name' => $request->get('report_name'),
|
'name' => $request->get('report_name'),
|
||||||
'options' => $request->except(['_token', 'report_name']),
|
'options' => $request->except(['_token', 'report_name']),
|
||||||
|
|
|
@ -357,6 +357,7 @@ Route::group(['middleware' => ['auth']], function () {
|
||||||
)->name('reports/export/accessories');
|
)->name('reports/export/accessories');
|
||||||
Route::get('reports/custom', [ReportsController::class, 'getCustomReport'])->name('reports/custom');
|
Route::get('reports/custom', [ReportsController::class, 'getCustomReport'])->name('reports/custom');
|
||||||
Route::post('reports/custom', [ReportsController::class, 'postCustom']);
|
Route::post('reports/custom', [ReportsController::class, 'postCustom']);
|
||||||
|
// @todo: change to saved-template?
|
||||||
Route::post('reports/savedtemplate', [SavedReportsController::class, 'store'])->name('savedreports/store');
|
Route::post('reports/savedtemplate', [SavedReportsController::class, 'store'])->name('savedreports/store');
|
||||||
|
|
||||||
Route::get(
|
Route::get(
|
||||||
|
|
|
@ -49,4 +49,22 @@ class SavedReportsTest extends TestCase
|
||||||
{
|
{
|
||||||
$this->markTestIncomplete();
|
$this->markTestIncomplete();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function testSavingReportRequiresValidFields()
|
||||||
|
{
|
||||||
|
$this->markTestIncomplete();
|
||||||
|
|
||||||
|
$this->actingAs(User::factory()->canViewReports()->create())
|
||||||
|
->post(route('savedreports/store'), [
|
||||||
|
//
|
||||||
|
])
|
||||||
|
->assertSessionHasErrors('report_name');
|
||||||
|
}
|
||||||
|
|
||||||
|
public function testSavingReportRequiresCorrectPermission()
|
||||||
|
{
|
||||||
|
$this->actingAs(User::factory()->create())
|
||||||
|
->post(route('savedreports/store'))
|
||||||
|
->assertForbidden();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue