From 5aa2f307cd7efa4d0a78ef841508ac09e4b16358 Mon Sep 17 00:00:00 2001
From: spencerrlongg <spencer@spencerlong.com>
Date: Fri, 22 Nov 2024 20:49:52 -0600
Subject: [PATCH] Remove debug dump statements

This commit removes various debug dump statements from BulkAssetsController and UpdateAssetAction. These changes clean up the code and improve readability by eliminating unnecessary debugging output. Maintaining clean code ensures better maintainability and performance.
---
 app/Actions/Assets/UpdateAssetAction.php             | 8 --------
 app/Http/Controllers/Assets/AssetsController.php     | 1 -
 app/Http/Controllers/Assets/BulkAssetsController.php | 1 -
 3 files changed, 10 deletions(-)

diff --git a/app/Actions/Assets/UpdateAssetAction.php b/app/Actions/Assets/UpdateAssetAction.php
index e7b09fc7ee..d53385f032 100644
--- a/app/Actions/Assets/UpdateAssetAction.php
+++ b/app/Actions/Assets/UpdateAssetAction.php
@@ -57,7 +57,6 @@ class UpdateAssetAction
         $asset->warranty_months = $warranty_months ?? $asset->warranty_months;
         $asset->purchase_cost = $purchase_cost ?? $asset->purchase_cost;
         if ($request->input('null_purchase_date') === '1') {
-            dump('filled');
             $asset->purchase_date = null;
             if (!($asset->eol_explicit)) {
                 $asset->asset_eol_date = null;
@@ -121,13 +120,10 @@ class UpdateAssetAction
 
         // This is a non-deployable status label - we should check the asset back in.
         if (($status && $status->getStatuslabelType() != 'deployable') && ($target = $asset->assignedTo)) {
-            dump('status logic');
-
             $originalValues = $asset->getRawOriginal();
             $asset->assigned_to = null;
             $asset->assigned_type = null;
             $asset->accepted = null;
-            dump($asset->assigned_to);
 
             event(new CheckoutableCheckedIn($asset, $target, auth()->user(), 'Checkin on asset update', date('Y-m-d H:i:s'), $originalValues));
             // reset this to null so checkout logic doesn't happen below
@@ -174,7 +170,6 @@ class UpdateAssetAction
 
         // the gui method
         //if (($model) && ($model->fieldset)) {
-        //    dump($model->fieldset->fields);
         //    foreach ($model->fieldset->fields as $field) {
         //
         //
@@ -210,8 +205,6 @@ class UpdateAssetAction
                         }
                     }
                     if ($field->field_encrypted == '1') {
-                        dump(Gate::allows('assets.view.encrypted_custom_fields'));
-                        dump(auth()->user()->can('assets.view.encrypted_custom_fields'));
                         if (Gate::allows('assets.view.encrypted_custom_fields')) {
                             $field_val = Crypt::encrypt($field_val);
                         } else {
@@ -243,7 +236,6 @@ class UpdateAssetAction
             }
 
             if (isset($target)) {
-                dump($target);
                 $asset->checkOut($target, auth()->user(), date('Y-m-d H:i:s'), '', 'Checked out on asset update', e($request->get('name')), $location);
             }
 
diff --git a/app/Http/Controllers/Assets/AssetsController.php b/app/Http/Controllers/Assets/AssetsController.php
index cf460ab401..3f889e65d6 100755
--- a/app/Http/Controllers/Assets/AssetsController.php
+++ b/app/Http/Controllers/Assets/AssetsController.php
@@ -264,7 +264,6 @@ class AssetsController extends Controller
                 asset_tag: $asset_tag, // same as serials
                 notes: $request->validated('notes'),
             );
-            dump('returned'.$asset->assigned_to);
             return redirect()->to(Helper::getRedirectOption($request, $updatedAsset->id, 'Assets'))
                 ->with('success', trans('admin/hardware/message.update.success'));
         } catch (ValidationException $e) {
diff --git a/app/Http/Controllers/Assets/BulkAssetsController.php b/app/Http/Controllers/Assets/BulkAssetsController.php
index 75deaa8c92..7bd9b7fd78 100644
--- a/app/Http/Controllers/Assets/BulkAssetsController.php
+++ b/app/Http/Controllers/Assets/BulkAssetsController.php
@@ -253,7 +253,6 @@ class BulkAssetsController extends Controller
             }
         }
         if (!empty($errors)) {
-            //dump($errors);
             return redirect($bulk_back_url)->with('bulk_asset_errors', $errors);
         }
         if ($custom_field_problem) {