From 3d8823ede53cd8b45c46e2e1d2071dbafb03e722 Mon Sep 17 00:00:00 2001 From: Sean Borg Date: Thu, 9 Jul 2020 20:47:18 +0100 Subject: [PATCH 1/3] Added #5762 Modify expected checkin dates It is now possible to edit expected checkin dates for assets in Actions > Edit Asset --- app/Http/Controllers/Assets/AssetsController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/Assets/AssetsController.php b/app/Http/Controllers/Assets/AssetsController.php index c6228d67d1..5affd481ec 100755 --- a/app/Http/Controllers/Assets/AssetsController.php +++ b/app/Http/Controllers/Assets/AssetsController.php @@ -186,7 +186,7 @@ class AssetsController extends Controller } if (isset($target)) { - $asset->checkOut($target, Auth::user(), date('Y-m-d H:i:s'), '', 'Checked out on asset creation', e($request->get('name')), $location); + $asset->checkOut($target, Auth::user(), date('Y-m-d H:i:s'), $request->input('expected_checkin', null), 'Checked out on asset creation', e($request->get('name')), $location); } $success = true; @@ -295,6 +295,7 @@ class AssetsController extends Controller $asset->purchase_cost = Helper::ParseFloat($request->input('purchase_cost', null)); $asset->purchase_date = $request->input('purchase_date', null); $asset->supplier_id = $request->input('supplier_id', null); + $asset->expected_checkin = $request->input('expected_checkin', null); // If the box isn't checked, it's not in the request at all. $asset->requestable = $request->filled('requestable'); From 7a433f8598a51e83572d5bceef56e1207c70a1ac Mon Sep 17 00:00:00 2001 From: Sean Borg Date: Thu, 9 Jul 2020 21:04:35 +0100 Subject: [PATCH 2/3] Updated purchase date format in hardware/bulkedit The Purchase date box in hardware/bulkedit was a different style to the normal hardware/{id}/edit It also prevents a strange bug I see in firefox when clicking the old datepicker it presented 2 datepicker boxes --- resources/views/hardware/bulk.blade.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/resources/views/hardware/bulk.blade.php b/resources/views/hardware/bulk.blade.php index 857720dc64..5cbe68a6ce 100755 --- a/resources/views/hardware/bulk.blade.php +++ b/resources/views/hardware/bulk.blade.php @@ -32,9 +32,11 @@
- - - {!! $errors->first('purchase_date', '') !!} +
+ + +
+ {!! $errors->first('purchase_date', ' :message') !!}
From 567a9639f4462b5de08fc0749b658199c1301dfe Mon Sep 17 00:00:00 2001 From: Sean Borg Date: Thu, 9 Jul 2020 21:08:35 +0100 Subject: [PATCH 3/3] Enhanced #5762 Able to bulk edit expected checkin date In light of the need to edit 500+ devices #5762 (comment) I added the expected checkin date to the bulk edit page for assets --- app/Http/Controllers/Assets/BulkAssetsController.php | 2 ++ resources/views/hardware/bulk.blade.php | 12 ++++++++++++ 2 files changed, 14 insertions(+) diff --git a/app/Http/Controllers/Assets/BulkAssetsController.php b/app/Http/Controllers/Assets/BulkAssetsController.php index 228b7f544d..1a6da89c96 100644 --- a/app/Http/Controllers/Assets/BulkAssetsController.php +++ b/app/Http/Controllers/Assets/BulkAssetsController.php @@ -78,6 +78,7 @@ class BulkAssetsController extends Controller $assets = array_keys($request->input('ids')); if (($request->filled('purchase_date')) + || ($request->filled('expected_checkin')) || ($request->filled('purchase_cost')) || ($request->filled('supplier_id')) || ($request->filled('order_number')) @@ -92,6 +93,7 @@ class BulkAssetsController extends Controller $this->update_array = []; $this->conditionallyAddItem('purchase_date') + ->conditionallyAddItem('expected_checkin') ->conditionallyAddItem('model_id') ->conditionallyAddItem('order_number') ->conditionallyAddItem('requestable') diff --git a/resources/views/hardware/bulk.blade.php b/resources/views/hardware/bulk.blade.php index 5cbe68a6ce..508b368d6f 100755 --- a/resources/views/hardware/bulk.blade.php +++ b/resources/views/hardware/bulk.blade.php @@ -39,6 +39,18 @@ {!! $errors->first('purchase_date', ' :message') !!} + +
+ +
+
+ + +
+ {!! $errors->first('expected_checkin', '') !!} +
+
+