mirror of
https://github.com/snipe/snipe-it.git
synced 2024-11-09 23:24:06 -08:00
Add tests for delete license endpoint
This commit is contained in:
parent
446e962a50
commit
60a54cee79
|
@ -220,7 +220,6 @@ class LicensesController extends Controller
|
||||||
*/
|
*/
|
||||||
public function destroy($id) : JsonResponse
|
public function destroy($id) : JsonResponse
|
||||||
{
|
{
|
||||||
//
|
|
||||||
$license = License::findOrFail($id);
|
$license = License::findOrFail($id);
|
||||||
$this->authorize('delete', $license);
|
$this->authorize('delete', $license);
|
||||||
|
|
||||||
|
|
88
tests/Feature/Licenses/Api/DeleteLicenseTest.php
Normal file
88
tests/Feature/Licenses/Api/DeleteLicenseTest.php
Normal file
|
@ -0,0 +1,88 @@
|
||||||
|
<?php
|
||||||
|
|
||||||
|
namespace Tests\Feature\Licenses\Api;
|
||||||
|
|
||||||
|
use App\Models\Company;
|
||||||
|
use App\Models\License;
|
||||||
|
use App\Models\User;
|
||||||
|
use Tests\Concerns\TestsMultipleFullCompanySupport;
|
||||||
|
use Tests\Concerns\TestsPermissionsRequirement;
|
||||||
|
use Tests\TestCase;
|
||||||
|
|
||||||
|
class DeleteLicenseTest extends TestCase implements TestsMultipleFullCompanySupport, TestsPermissionsRequirement
|
||||||
|
{
|
||||||
|
public function testRequiresPermission()
|
||||||
|
{
|
||||||
|
$license = License::factory()->create();
|
||||||
|
|
||||||
|
$this->actingAsForApi(User::factory()->create())
|
||||||
|
->deleteJson(route('api.licenses.destroy', $license))
|
||||||
|
->assertForbidden();
|
||||||
|
}
|
||||||
|
|
||||||
|
public function testAdheresToMultipleFullCompanySupportScoping()
|
||||||
|
{
|
||||||
|
[$companyA, $companyB] = Company::factory()->count(2)->create();
|
||||||
|
|
||||||
|
$licenseA = License::factory()->for($companyA)->create();
|
||||||
|
$licenseB = License::factory()->for($companyB)->create();
|
||||||
|
$licenseC = License::factory()->for($companyB)->create();
|
||||||
|
|
||||||
|
$superUser = $companyA->users()->save(User::factory()->superuser()->make());
|
||||||
|
$userInCompanyA = $companyA->users()->save(User::factory()->deleteLicenses()->make());
|
||||||
|
$userInCompanyB = $companyB->users()->save(User::factory()->deleteLicenses()->make());
|
||||||
|
|
||||||
|
$this->settings->enableMultipleFullCompanySupport();
|
||||||
|
|
||||||
|
$this->actingAsForApi($userInCompanyA)
|
||||||
|
->deleteJson(route('api.licenses.destroy', $licenseB))
|
||||||
|
->assertStatusMessageIs('error');
|
||||||
|
|
||||||
|
$this->actingAsForApi($userInCompanyB)
|
||||||
|
->deleteJson(route('api.licenses.destroy', $licenseA))
|
||||||
|
->assertStatusMessageIs('error');
|
||||||
|
|
||||||
|
$this->actingAsForApi($superUser)
|
||||||
|
->deleteJson(route('api.licenses.destroy', $licenseC))
|
||||||
|
->assertStatusMessageIs('success');
|
||||||
|
|
||||||
|
$this->assertNotSoftDeleted($licenseA);
|
||||||
|
$this->assertNotSoftDeleted($licenseB);
|
||||||
|
$this->assertSoftDeleted($licenseC);
|
||||||
|
}
|
||||||
|
|
||||||
|
public function testLicenseCannotBeDeletedIfStillAssigned()
|
||||||
|
{
|
||||||
|
$license = License::factory()->create(['seats' => 2]);
|
||||||
|
$license->freeSeat()->update(['assigned_to' => User::factory()->create()->id]);
|
||||||
|
|
||||||
|
$this->actingAsForApi(User::factory()->deleteLicenses()->create())
|
||||||
|
->deleteJson(route('api.licenses.destroy', $license))
|
||||||
|
->assertStatusMessageIs('error');
|
||||||
|
|
||||||
|
$this->assertNotSoftDeleted($license);
|
||||||
|
}
|
||||||
|
|
||||||
|
public function testCanDeleteLicense()
|
||||||
|
{
|
||||||
|
$license = License::factory()->create();
|
||||||
|
|
||||||
|
$this->actingAsForApi(User::factory()->deleteLicenses()->create())
|
||||||
|
->deleteJson(route('api.licenses.destroy', $license))
|
||||||
|
->assertStatusMessageIs('success');
|
||||||
|
|
||||||
|
$this->assertSoftDeleted($license);
|
||||||
|
}
|
||||||
|
|
||||||
|
public function testLicenseSeatsAreDeletedWhenLicenseIsDeleted()
|
||||||
|
{
|
||||||
|
$license = License::factory()->create(['seats' => 2]);
|
||||||
|
|
||||||
|
$this->assertTrue($license->fresh()->licenseseats->isNotEmpty(), 'License seats not created like expected');
|
||||||
|
|
||||||
|
$this->actingAsForApi(User::factory()->deleteLicenses()->create())
|
||||||
|
->deleteJson(route('api.licenses.destroy', $license));
|
||||||
|
|
||||||
|
$this->assertTrue($license->fresh()->licenseseats->isEmpty());
|
||||||
|
}
|
||||||
|
}
|
Loading…
Reference in a new issue