DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-01-27 21:50:58 -08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Merge pull request #11663 from inietov/fixes/user_cant_be_deleted_if_has_consumables

Browse source 
Prevent to delete a user if still has consumables associated to them
This commit is contained in:
snipe 2022-08-14 13:41:09 -07:00 committed by GitHub
parent 491cdd4de6 db53a00d3f
commit 60d1578a01
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/Http/Controllers/Api/UsersController.php
View file

@ -441,6 +441,10 @@ class UsersController extends Controller
return response()->json(Helper::formatStandardApiResponse('error', null, 'This user still has '.$user->accessories->count().' accessories associated with them.')); return response()->json(Helper::formatStandardApiResponse('error', null, 'This user still has '.$user->accessories->count().' accessories associated with them.'));
} }
if (($user->consumables) && ($user->consumables->count() > 0)) {
return response()->json(Helper::formatStandardApiResponse('error', null, 'This user still has '.$user->consumables->count().' consumables associated with them.'));
}
if (($user->managedLocations()) && ($user->managedLocations()->count() > 0)) { if (($user->managedLocations()) && ($user->managedLocations()->count() > 0)) {
return response()->json(Helper::formatStandardApiResponse('error', null, 'This user still has '.$user->managedLocations()->count().' locations that they manage.')); return response()->json(Helper::formatStandardApiResponse('error', null, 'This user still has '.$user->managedLocations()->count().' locations that they manage.'));
} }

6
app/Http/Controllers/Users/UsersController.php
View file

@ -348,6 +348,12 @@ class UsersController extends Controller
->with('error', 'This user still has '.$accessoriesCount.' accessories associated with them.'); ->with('error', 'This user still has '.$accessoriesCount.' accessories associated with them.');
} }
if (($user->consumables()) && (($consumablesCount = $user->consumables()->count())) > 0) {
// Redirect to the user management page
return redirect()->route('users.index')
->with('error', 'This user still has '.$consumablesCount.' consumables associated with them.');
}
if (($user->managedLocations()) && (($managedLocationsCount = $user->managedLocations()->count())) > 0) { if (($user->managedLocations()) && (($managedLocationsCount = $user->managedLocations()->count())) > 0) {
// Redirect to the user management page // Redirect to the user management page
return redirect()->route('users.index') return redirect()->route('users.index')