Merge pull request #12954 from marcusmoore/fixes/test-suite-fixes

Clear the settings cache on app destruction

tests/Support/InteractsWithSettings.php

@@ -2,12 +2,16 @@
 
 namespace Tests\Support;
 
+use App\Models\Setting;
+
 trait InteractsWithSettings
 {
     protected Settings $settings;
 
-    public function setUpSettings()
+    public function initializeSettings()
     {
         $this->settings = Settings::initialize();
+
+        $this->beforeApplicationDestroyed(fn() => Setting::$_cache = null);
     }
 }

tests/TestCase.php

@@ -23,7 +23,7 @@ abstract class TestCase extends BaseTestCase
         $this->withoutMiddleware($this->globallyDisabledMiddleware);
 
         if (collect(class_uses_recursive($this))->contains(InteractsWithSettings::class)) {
-            $this->setUpSettings();
+            $this->initializeSettings();
         }
     }
 }

tests/Unit/AssetMaintenanceTest.php

@@ -3,10 +3,13 @@ namespace Tests\Unit;
 
 use App\Models\AssetMaintenance;
 use Carbon\Carbon;
+use Tests\Support\InteractsWithSettings;
 use Tests\TestCase;
 
 class AssetMaintenanceTest extends TestCase
 {
+    use InteractsWithSettings;
+
     public function testZerosOutWarrantyIfBlank()
     {
         $c = new AssetMaintenance;

tests/Unit/AssetModelTest.php

@@ -4,10 +4,13 @@ namespace Tests\Unit;
 use App\Models\Asset;
 use App\Models\Category;
 use App\Models\AssetModel;
+use Tests\Support\InteractsWithSettings;
 use Tests\TestCase;
 
 class AssetModelTest extends TestCase
 {
+    use InteractsWithSettings;
+
     public function testAnAssetModelZerosOutBlankEols()
     {
         $am = new AssetModel;

tests/Unit/AssetTest.php

@@ -5,10 +5,13 @@ use App\Models\Asset;
 use App\Models\AssetModel;
 use App\Models\Category;
 use Carbon\Carbon;
+use Tests\Support\InteractsWithSettings;
 use Tests\TestCase;
 
 class AssetTest extends TestCase
 {
+    use InteractsWithSettings;
+
     // public function testAutoIncrementMixed()
     // {
     //     $expected = '123411';

tests/Unit/CategoryTest.php

@@ -4,10 +4,13 @@ namespace Tests\Unit;
 use App\Models\Category;
 use App\Models\AssetModel;
 use App\Models\Asset;
+use Tests\Support\InteractsWithSettings;
 use Tests\TestCase;
 
 class CategoryTest extends TestCase
 {
+    use InteractsWithSettings;
+
     public function testFailsEmptyValidation()
     {
         // An Asset requires a name, a qty, and a category_id.

tests/Unit/ComponentTest.php

@@ -5,10 +5,13 @@ use App\Models\Category;
 use App\Models\Company;
 use App\Models\Component;
 use App\Models\Location;
+use Tests\Support\InteractsWithSettings;
 use Tests\TestCase;
 
 class ComponentTest extends TestCase
 {
+    use InteractsWithSettings;
+
     public function testAComponentBelongsToACompany()
     {
         $component = Component::factory()

tests/Unit/DepreciationTest.php

@@ -5,10 +5,13 @@ use App\Models\Depreciation;
 use App\Models\Category;
 use App\Models\License;
 use App\Models\AssetModel;
+use Tests\Support\InteractsWithSettings;
 use Tests\TestCase;
 
 class DepreciationTest extends TestCase
 {
+    use InteractsWithSettings;
+
     public function testADepreciationHasModels()
     {
         $depreciation = Depreciation::factory()->create();

tests/Unit/NotificationTest.php

@@ -8,10 +8,13 @@ use App\Models\Category;
 use Carbon\Carbon;
 use App\Notifications\CheckoutAssetNotification;
 use Illuminate\Support\Facades\Notification;
+use Tests\Support\InteractsWithSettings;
 use Tests\TestCase;
 
 class NotificationTest extends TestCase
 {
+    use InteractsWithSettings;
+
     public function testAUserIsEmailedIfTheyCheckoutAnAssetWithEULA()
     {
         $admin = User::factory()->superuser()->create();

tests/Unit/SnipeModelTest.php

@@ -2,10 +2,13 @@
 namespace Tests\Unit;
 
 use App\Models\SnipeModel;
+use Tests\Support\InteractsWithSettings;
 use Tests\TestCase;
 
 class SnipeModelTest extends TestCase
 {
+    use InteractsWithSettings;
+
     public function testSetsPurchaseDatesAppropriately()
     {
         $c = new SnipeModel;