DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-01-12 14:27:33 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

cleanup

Browse source
This commit is contained in:
spencerrlongg 2023-09-13 17:58:33 -05:00
parent ef64843d2f
commit 64a9859efd
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/Importer/ItemImporter.php
View file

@ -245,7 +245,6 @@ class ItemImporter extends Importer
$this->log('Asset Model Updated'); $this->log('Asset Model Updated');
return $asset_model->id; return $asset_model->id;
// here
} }
$this->log('No Matching Model, Creating a new one'); $this->log('No Matching Model, Creating a new one');

5
database/migrations/2023_07_13_052204_denormalized_eol_and_add_column_for_explicit_date_to_assets.php
View file

@ -21,7 +21,7 @@ class DenormalizedEolAndAddColumnForExplicitDateToAssets extends Migration
// Update the eol_explicit column with the value from asset_eol_date if it exists and is different from the calculated value // Update the eol_explicit column with the value from asset_eol_date if it exists and is different from the calculated value
$assetsWithEolDates = Asset::whereNotNull('asset_eol_date')->chunk(100, function ($assetsWithEolDates) { Asset::whereNotNull('asset_eol_date')->chunk(100, function ($assetsWithEolDates) {
foreach ($assetsWithEolDates as $asset) { foreach ($assetsWithEolDates as $asset) {
if ($asset->asset_eol_date && $asset->purchase_date) { if ($asset->asset_eol_date && $asset->purchase_date) {
$months = Carbon::parse($asset->asset_eol_date)->diffInMonths($asset->purchase_date); $months = Carbon::parse($asset->asset_eol_date)->diffInMonths($asset->purchase_date);
@ -35,10 +35,9 @@ class DenormalizedEolAndAddColumnForExplicitDateToAssets extends Migration
} }
} }
}); });
unset($assetsWithEolDates);
// Update the asset_eol_date column with the calculated value if it doesn't exist // Update the asset_eol_date column with the calculated value if it doesn't exist
$assets = Asset::whereNull('asset_eol_date')->chunk(100, function ($assets) { Asset::whereNull('asset_eol_date')->chunk(100, function ($assets) {
foreach ($assets as $asset) { foreach ($assets as $asset) {
$model = Asset::find($asset->id)->model; $model = Asset::find($asset->id)->model;
if (!empty($model->eol)) { if (!empty($model->eol)) {