diff --git a/app/Listeners/CheckoutableListener.php b/app/Listeners/CheckoutableListener.php index b297a4f720..0811e9ee57 100644 --- a/app/Listeners/CheckoutableListener.php +++ b/app/Listeners/CheckoutableListener.php @@ -106,7 +106,13 @@ class CheckoutableListener } } } catch (ClientException $e) { - Log::error("ClientException caught during checkin notification: " . $e->getMessage()); + if (strpos($e->getMessage(), 'channel_not_found') !== false) { + Log::warning(Setting::getSettings()->webhook_selected." notification failed: " . $e->getMessage()); + return redirect()->back()->with('warning', ucfirst(Setting::getSettings()->webhook_selected) .trans('admin/settings/message.webhook.webhook_channel_not_found') ); + } + else { + Log::error("ClientException caught during checkin notification: " . $e->getMessage()); + } return redirect()->back()->with('warning', ucfirst(Setting::getSettings()->webhook_selected) .trans('admin/settings/message.webhook.webhook_fail') ); } catch (Exception $e) { Log::error(ucfirst(Setting::getSettings()->webhook_selected) . ' webhook notification failed:', [ @@ -156,7 +162,7 @@ class CheckoutableListener $ccEmails = array_filter($adminCcEmailsArray); $mailable = $this->getCheckinMailType($event); $notifiable = $this->getNotifiables($event); - if ($event->checkedOutTo->locale){ + if ($event->checkedOutTo?->locale) { $mailable->locale($event->checkedOutTo->locale); } // Send email notifications @@ -196,8 +202,14 @@ class CheckoutableListener } } } catch (ClientException $e) { - Log::error("ClientException caught during checkin notification: " . $e->getMessage()); - return redirect()->back()->with('warning', ucfirst(Setting::getSettings()->webhook_selected) .trans('admin/settings/message.webhook.webhook_fail')); + if (strpos($e->getMessage(), 'channel_not_found') !== false) { + Log::warning(Setting::getSettings()->webhook_selected." notification failed: " . $e->getMessage()); + return redirect()->back()->with('warning', ucfirst(Setting::getSettings()->webhook_selected) .trans('admin/settings/message.webhook.webhook_channel_not_found') ); + } + else { + Log::error("ClientException caught during checkin notification: " . $e->getMessage()); + return redirect()->back()->with('warning', ucfirst(Setting::getSettings()->webhook_selected) . trans('admin/settings/message.webhook.webhook_fail')); + } } catch (Exception $e) { Log::error(ucfirst(Setting::getSettings()->webhook_selected) . ' webhook notification failed:', [ 'error' => $e->getMessage(), diff --git a/app/Observers/AssetObserver.php b/app/Observers/AssetObserver.php index 421a93b9d7..b44d098123 100644 --- a/app/Observers/AssetObserver.php +++ b/app/Observers/AssetObserver.php @@ -48,7 +48,7 @@ class AssetObserver $changed = []; foreach ($asset->getRawOriginal() as $key => $value) { - if ($asset->getRawOriginal()[$key] != $asset->getAttributes()[$key]) { + if ((array_key_exists($key, $asset->getAttributes())) && ($asset->getRawOriginal()[$key] != $asset->getAttributes()[$key])) { $changed[$key]['old'] = $asset->getRawOriginal()[$key]; $changed[$key]['new'] = $asset->getAttributes()[$key]; } diff --git a/app/View/Label.php b/app/View/Label.php index bafe97ffef..22dbe6d26e 100644 --- a/app/View/Label.php +++ b/app/View/Label.php @@ -116,12 +116,9 @@ class Label implements View } } - if ($template->getSupport2DBarcode()) { + if ($template->getSupport2DBarcode()) { $barcode2DType = $settings->label2_2d_type; - $barcode2DType = ($barcode2DType == 'default') ? - $settings->barcode_type : - $barcode2DType; - if (($barcode2DType != 'none') && (!is_null($barcode2DType))) { + if (($barcode2DType != 'none') && (!is_null($barcode2DType))) { switch ($settings->label2_2d_target) { case 'ht_tag': $barcode2DTarget = route('ht/assetTag', $asset->asset_tag); diff --git a/resources/lang/en-US/admin/settings/message.php b/resources/lang/en-US/admin/settings/message.php index 98a8893937..a256402c68 100644 --- a/resources/lang/en-US/admin/settings/message.php +++ b/resources/lang/en-US/admin/settings/message.php @@ -46,5 +46,6 @@ return [ 'error_redirect' => 'ERROR: 301/302 :endpoint returns a redirect. For security reasons, we don’t follow redirects. Please use the actual endpoint.', 'error_misc' => 'Something went wrong. :( ', 'webhook_fail' => ' webhook notification failed: Check to make sure the URL is still valid.', + 'webhook_channel_not_found' => ' webhook channel not found.' ] ]; diff --git a/resources/views/settings/backups.blade.php b/resources/views/settings/backups.blade.php index 6313a6e404..a5d06738bf 100644 --- a/resources/views/settings/backups.blade.php +++ b/resources/views/settings/backups.blade.php @@ -12,7 +12,7 @@
- {{ Form::hidden('_token', csrf_token()) }} + @csrf
diff --git a/resources/views/settings/labels.blade.php b/resources/views/settings/labels.blade.php index fa8c5dc858..28967e7eda 100644 --- a/resources/views/settings/labels.blade.php +++ b/resources/views/settings/labels.blade.php @@ -308,31 +308,31 @@ @else - {{ Form::hidden('label2_template', old('label2_template', $setting->label2_template)) }} - {{ Form::hidden('label2_title', old('label2_title', $setting->label2_title)) }} - {{ Form::hidden('label2_asset_logo', old('label2_asset_logo', $setting->label2_asset_logo)) }} - {{ Form::hidden('label2_fields', old('label2_fields', $setting->label2_fields)) }} + + + + @endif @if ($setting->label2_enable && ($setting->label2_template != 'DefaultLabel')) - {{ Form::hidden('labels_per_page', old('labels_per_page', $setting->labels_per_page)) }} - {{ Form::hidden('labels_fontsize', old('labels_fontsize', $setting->labels_fontsize)) }} - {{ Form::hidden('labels_width', old('labels_width', $setting->labels_width)) }} - {{ Form::hidden('labels_height', old('labels_height', $setting->labels_height)) }} - {{ Form::hidden('labels_display_sgutter', old('labels_display_sgutter', $setting->labels_display_sgutter)) }} - {{ Form::hidden('labels_display_bgutter', old('labels_display_bgutter', $setting->labels_display_bgutter)) }} - {{ Form::hidden('labels_pmargin_top', old('labels_pmargin_top', $setting->labels_pmargin_top)) }} - {{ Form::hidden('labels_pmargin_bottom', old('labels_pmargin_bottom', $setting->labels_pmargin_bottom)) }} - {{ Form::hidden('labels_pmargin_left', old('labels_pmargin_left', $setting->labels_pmargin_left)) }} - {{ Form::hidden('labels_pmargin_right', old('labels_pmargin_right', $setting->labels_pmargin_right)) }} - {{ Form::hidden('labels_pagewidth', old('labels_pagewidth', $setting->labels_pagewidth)) }} - {{ Form::hidden('labels_pageheight', old('labels_pageheight', $setting->labels_pageheight)) }} - {{ Form::hidden('labels_display_name', old('labels_display_name', $setting->labels_display_name)) }} - {{ Form::hidden('labels_display_serial', old('labels_display_serial', $setting->labels_display_serial)) }} - {{ Form::hidden('labels_display_tag', old('labels_display_tag', $setting->labels_display_tag)) }} - {{ Form::hidden('labels_display_model', old('labels_display_model', $setting->labels_display_model)) }} - {{ Form::hidden('labels_display_company_name', old('labels_display_company_name', $setting->labels_display_company_name)) }} + + + + + + + + + + + + + + + + + @else