DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-01-11 22:07:29 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

gets rid of depreciate

Browse source
This commit is contained in:
spencerrlongg 2023-11-30 16:08:49 -06:00
parent 68d85385a2
commit 6e5f296a13
3 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/Http/Controllers/Api/AssetsController.php
View file

@ -545,7 +545,6 @@ class AssetsController extends Controller
// @todo: verify eol is working as expected - move to request? or do I want this at all? // @todo: verify eol is working as expected - move to request? or do I want this at all?
// might just remove this and then use the method from here https://github.com/snipe/snipe-it/pull/13846 // might just remove this and then use the method from here https://github.com/snipe/snipe-it/pull/13846
$asset->asset_eol_date = $request->validated()['asset_eol_date'] ?? $asset->present()->eol_date(); // so this isn't really necessary, because it's happening on the observer - but that might change? $asset->asset_eol_date = $request->validated()['asset_eol_date'] ?? $asset->present()->eol_date(); // so this isn't really necessary, because it's happening on the observer - but that might change?
$asset->depreciate = '0';
/** /**
* this is here just legacy reasons. Api\AssetController * this is here just legacy reasons. Api\AssetController

1
app/Http/Controllers/Assets/AssetsController.php
View file

@ -131,7 +131,6 @@ class AssetsController extends Controller
$asset->order_number = $request->input('order_number'); $asset->order_number = $request->input('order_number');
$asset->notes = $request->input('notes'); $asset->notes = $request->input('notes');
$asset->user_id = Auth::id(); $asset->user_id = Auth::id();
$asset->depreciate = '0';
$asset->status_id = request('status_id'); $asset->status_id = request('status_id');
$asset->warranty_months = request('warranty_months', null); $asset->warranty_months = request('warranty_months', null);
$asset->purchase_cost = request('purchase_cost'); $asset->purchase_cost = request('purchase_cost');

2
tests/Feature/Api/Assets/AssetStoreTest.php
View file

@ -73,8 +73,6 @@ class AssetStoreTest extends TestCase
$this->assertEquals($userAssigned->id, $asset->assigned_to); $this->assertEquals($userAssigned->id, $asset->assigned_to);
// @todo: This is not in the docs but it's in the controller (company_id) // @todo: This is not in the docs but it's in the controller (company_id)
$this->assertTrue($asset->company->is($company)); $this->assertTrue($asset->company->is($company));
// @todo: this is explicitly set 0 in the controller but they docs say they are customizable
// $this->assertTrue($asset->depreciate);
// @todo: this is in the docs but not the controller // @todo: this is in the docs but not the controller
// $this->assertEquals('2023-09-03', $asset->last_audit_date); // $this->assertEquals('2023-09-03', $asset->last_audit_date);
// @todo: this is set to rtd_location_id in the controller but customizable in the docs // @todo: this is set to rtd_location_id in the controller but customizable in the docs