From 759c8c8f5c04a643345b3fb21f6dbe3d98adcfc7 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Wed, 19 Feb 2025 12:36:50 -0800 Subject: [PATCH] Catch TypeError in addition to Exceptions when rendering barcodes --- app/Http/Controllers/Assets/AssetsController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/Assets/AssetsController.php b/app/Http/Controllers/Assets/AssetsController.php index 9cb88cfb93..df7c134527 100755 --- a/app/Http/Controllers/Assets/AssetsController.php +++ b/app/Http/Controllers/Assets/AssetsController.php @@ -30,6 +30,7 @@ use Illuminate\Http\Response; use Illuminate\Contracts\View\View; use Illuminate\Http\RedirectResponse; use Symfony\Component\HttpFoundation\BinaryFileResponse; +use TypeError; /** * This class controls all actions related to assets for @@ -590,7 +591,7 @@ class AssetsController extends Controller file_put_contents($barcode_file, $barcode_obj->getPngData()); return response($barcode_obj->getPngData())->header('Content-type', 'image/png'); - } catch (\Exception $e) { + } catch (\Exception|TypeError $e) { Log::debug('The barcode format is invalid.'); return response(file_get_contents(public_path('uploads/barcodes/invalid_barcode.gif')))->header('Content-type', 'image/gif');