DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-03-05 20:52:15 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add authorization check

Browse source
This commit is contained in:
Marcus Moore 2024-10-23 16:11:10 -07:00
parent e390a95bd3
commit 84f6638f50
No known key found for this signature in database
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/Http/Controllers/ReportTemplatesController.php
View file

@ -47,6 +47,8 @@ class ReportTemplatesController extends Controller
public function edit($reportId): View public function edit($reportId): View
{ {
$this->authorize('reports.view');
return view('reports/custom', [ return view('reports/custom', [
'customfields' => CustomField::get(), 'customfields' => CustomField::get(),
'template' => ReportTemplate::findOrFail($reportId), 'template' => ReportTemplate::findOrFail($reportId),

2
tests/Feature/ReportTemplates/EditReportTemplateTest.php
View file

@ -11,8 +11,6 @@ class EditReportTemplateTest extends TestCase implements TestsPermissionsRequire
{ {
public function testRequiresPermission() public function testRequiresPermission()
{ {
$this->markTestIncomplete('Returning 404 instead of 403...');
$this->actingAs(User::factory()->create()) $this->actingAs(User::factory()->create())
->get(route('report-templates.edit', ReportTemplate::factory()->create())) ->get(route('report-templates.edit', ReportTemplate::factory()->create()))
->assertForbidden(); ->assertForbidden();