diff --git a/app/Http/Controllers/ProfileController.php b/app/Http/Controllers/ProfileController.php index 739376e3ab..cf5f49feb0 100755 --- a/app/Http/Controllers/ProfileController.php +++ b/app/Http/Controllers/ProfileController.php @@ -67,37 +67,9 @@ class ProfileController extends Controller $user->location_id = $request->input('location_id'); } + // Handle the avatar upload and/or delete if necessary + app('\App\Http\Requests\ImageUploadRequest')->handleImages($user, 600, 'avatar', 'avatars', 'avatar'); - if ($request->input('avatar_delete') == 1) { - $user->avatar = null; - } - - - if ($request->hasFile('avatar')) { - $path = 'avatars'; - - if (! Storage::disk('public')->exists($path)) { - Storage::disk('public')->makeDirectory($path, 775); - } - - $upload = $image = $request->file('avatar'); - $ext = $image->getClientOriginalExtension(); - $file_name = 'avatar-'.str_random(18).'.'.$ext; - - if ($image->getClientOriginalExtension() != 'svg') { - $upload = Image::make($image->getRealPath())->resize(84, 84); - } - - // This requires a string instead of an object, so we use ($string) - Storage::disk('public')->put($path.'/'.$file_name, (string) $upload->encode()); - - // Remove Current image if exists - if (($user->avatar) && (Storage::disk('public')->exists($path.'/'.$user->avatar))) { - Storage::disk('public')->delete($path.'/'.$user->avatar); - } - - $user->avatar = $file_name; - } if ($user->save()) { return redirect()->route('profile')->with('success', 'Account successfully updated'); diff --git a/app/Http/Controllers/Users/UsersController.php b/app/Http/Controllers/Users/UsersController.php index 52d423036f..2a34992552 100755 --- a/app/Http/Controllers/Users/UsersController.php +++ b/app/Http/Controllers/Users/UsersController.php @@ -131,7 +131,7 @@ class UsersController extends Controller $user->permissions = json_encode($permissions_array); // we have to invoke the - app(\App\Http\Requests\ImageUploadRequest::class)->handleImages($user, 600, 'image', 'avatars', 'avatar'); + app(ImageUploadRequest::class)->handleImages($user, 600, 'avatar', 'avatars', 'avatar'); if ($user->save()) { if ($request->filled('groups')) { @@ -296,7 +296,7 @@ class UsersController extends Controller $user->permissions = json_encode($permissions_array); // Handle uploaded avatar - app(\App\Http\Requests\ImageUploadRequest::class)->handleImages($user, 600, 'avatar', 'avatars', 'avatar'); + app(ImageUploadRequest::class)->handleImages($user, 600, 'avatar', 'avatars', 'avatar'); //\Log::debug(print_r($user, true)); diff --git a/app/Http/Requests/ImageUploadRequest.php b/app/Http/Requests/ImageUploadRequest.php index 1b0b051366..6fb6ead210 100644 --- a/app/Http/Requests/ImageUploadRequest.php +++ b/app/Http/Requests/ImageUploadRequest.php @@ -63,11 +63,13 @@ class ImageUploadRequest extends Request * @param string $path location for uploaded images, defaults to uploads/plural of item type. * @return SnipeModel Target asset is being checked out to. */ - public function handleImages($item, $w = 600, $form_fieldname = null, $path = null, $db_fieldname = 'image') + public function handleImages($item, $w = 600, $form_fieldname = 'image', $path = null, $db_fieldname = 'image') { + $type = strtolower(class_basename(get_class($item))); if (is_null($path)) { + $path = str_plural($type); if ($type == 'assetmodel') { @@ -79,42 +81,31 @@ class ImageUploadRequest extends Request } } - if (is_null($form_fieldname)) { - $form_fieldname = 'image'; - } - - // This is dumb, but we need it for overriding field names for exceptions like avatars and logo uploads - if (is_null($db_fieldname)) { - $use_db_field = $form_fieldname; - } else { - $use_db_field = $db_fieldname; - } - - - // ConvertBase64ToFiles just changes object type, - // as it cannot currently insert files to $this->files if ($this->offsetGet($form_fieldname) instanceof UploadedFile) { - $image=$this->offsetGet($form_fieldname); + $image = $this->offsetGet($form_fieldname); + \Log::debug('Image is an instance of UploadedFile'); + } elseif ($this->hasFile($form_fieldname)) { + $image = $this->file($form_fieldname); + \Log::debug('Just use regular upload for '.$form_fieldname); } else { - if ($this->hasFile($form_fieldname)) { - $image = $this->file($form_fieldname); - } + \Log::debug('No image found for form fieldname: '.$form_fieldname); } if (isset($image)) { - \Log::debug($image); if (!config('app.lock_passwords')) { $ext = $image->getClientOriginalExtension(); - $file_name = $type.'-'.$form_fieldname.'-'.str_random(10).'.'.$ext; + $file_name = $type.'-'.$form_fieldname.'-'.$item->id.'-'.str_random(10).'.'.$ext; \Log::info('File name will be: '.$file_name); \Log::debug('File extension is: '.$ext); if (($image->getClientOriginalExtension() !== 'webp') && ($image->getClientOriginalExtension() !== 'svg')) { + \Log::debug('Not an SVG or webp - resize'); \Log::debug('Trying to upload to: '.$path.'/'.$file_name); + $upload = Image::make($image->getRealPath())->resize(null, $w, function ($constraint) { $constraint->aspectRatio(); $constraint->upsize(); @@ -122,6 +113,7 @@ class ImageUploadRequest extends Request // This requires a string instead of an object, so we use ($string) Storage::disk('public')->put($path.'/'.$file_name, (string) $upload->encode()); + } else { // If the file is a webp, we need to just move it since webp support // needs to be compiled into gd for resizing to be available @@ -146,30 +138,30 @@ class ImageUploadRequest extends Request } // Remove Current image if exists - if (($item->{$use_db_field}!='') && (Storage::disk('public')->exists($path.'/'.$item->{$use_db_field}))) { + if (($item->{$form_fieldname}!='') && (Storage::disk('public')->exists($path.'/'.$item->{$db_fieldname}))) { \Log::debug('A file already exists that we are replacing - we should delete the old one.'); try { - Storage::disk('public')->delete($path.'/'.$item->{$use_db_field}); + Storage::disk('public')->delete($path.'/'.$item->{$form_fieldname}); \Log::debug('Old file '.$path.'/'.$file_name.' has been deleted.'); } catch (\Exception $e) { \Log::debug('Could not delete old file. '.$path.'/'.$file_name.' does not exist?'); } } - $item->{$use_db_field} = $file_name; + $item->{$db_fieldname} = $file_name; } + // If the user isn't uploading anything new but wants to delete their old image, do so - } else { - if ($this->input('image_delete') == '1') { - \Log::debug('Deleting image'); - try { - Storage::disk('public')->delete($path.'/'.$item->{$use_db_field}); - $item->{$use_db_field} = null; - } catch (\Exception $e) { - \Log::debug($e); - } + } elseif ($this->input('image_delete') == '1') { + \Log::debug('Deleting image'); + try { + Storage::disk('public')->delete($path.'/'.$item->{$db_fieldname}); + $item->{$db_fieldname} = null; + } catch (\Exception $e) { + \Log::debug($e); } + } return $item; diff --git a/app/Models/User.php b/app/Models/User.php index 399008430b..34c0af6b2e 100755 --- a/app/Models/User.php +++ b/app/Models/User.php @@ -61,7 +61,9 @@ class User extends SnipeModel implements AuthenticatableContract, AuthorizableCo 'remote', 'start_date', 'end_date', - 'scim_externalid' + 'scim_externalid', + 'avatar', + 'gravatar', ]; protected $casts = [ diff --git a/resources/lang/en/general.php b/resources/lang/en/general.php index acc00501ed..43d8b3d9e1 100644 --- a/resources/lang/en/general.php +++ b/resources/lang/en/general.php @@ -3,6 +3,7 @@ return [ 'accessories' => 'Accessories', 'activated' => 'Activated', + 'accepted_date' => 'Date Accepted', 'accessory' => 'Accessory', 'accessory_report' => 'Accessory Report', 'action' => 'Action', @@ -27,7 +28,9 @@ return [ 'audit' => 'Audit', 'audit_report' => 'Audit Log', 'assets' => 'Assets', + 'assigned_date' => 'Date Assigned', 'assigned_to' => 'Assigned to :name', + 'assignee' => 'Assigned to', 'avatar_delete' => 'Delete Avatar', 'avatar_upload' => 'Upload Avatar', 'back' => 'Back', diff --git a/resources/views/accessories/edit.blade.php b/resources/views/accessories/edit.blade.php index d6233d4e5a..532336182b 100755 --- a/resources/views/accessories/edit.blade.php +++ b/resources/views/accessories/edit.blade.php @@ -21,22 +21,27 @@ @include ('partials.forms.edit.purchase_cost') @include ('partials.forms.edit.quantity') @include ('partials.forms.edit.minimum_quantity') - +@include ('partials.forms.edit.notes') -@if ($item->image) -
- Assigned on: {{$check_out_date}}
- Assigned to: {{$assigned_to}}
- Accepted on: {{$accepted_date}}
+ {{ trans('general.assigned_date') }}: {{$check_out_date}}
+ {{ trans('general.assignee') }}: {{$assigned_to}}
+ {{ trans('general.accepted_date') }}: {{$accepted_date}}
-Assigned on: {{$check_out_date}}
-Assigned to: {{$assigned_to}}
-Accepted on: {{$accepted_date}}
+ {{ trans('general.assigned_date') }}: {{$check_out_date}}
+ {{ trans('general.assignee') }}: {{$assigned_to}}
+ {{ trans('general.accepted_date') }}: {{$accepted_date}}
- Assigned on: {{$check_out_date}}
- Assigned to: {{$assigned_to}}
- Accepted on: {{$accepted_date}}
+ {{ trans('general.assigned_date') }}: {{$check_out_date}}
+ {{ trans('general.assignee') }}: {{$assigned_to}}
+ {{ trans('general.accepted_date') }}: {{$accepted_date}}
- Assigned on: {{$check_out_date}}
- Assigned to: {{$assigned_to}}
- Accepted on: {{$accepted_date}}
+ {{ trans('general.assigned_date') }}: {{$check_out_date}}
+ {{ trans('general.assignee') }}: {{$assigned_to}}
+ {{ trans('general.accepted_date') }}: {{$accepted_date}}
- Assigned on: {{$check_out_date}}
- Assigned to: {{$assigned_to}}
- Accepted on: {{$accepted_date}}
+ {{ trans('general.assigned_date') }}: {{$check_out_date}}
+ {{ trans('general.assignee') }}: {{$assigned_to}}
+ {{ trans('general.accepted_date') }}: {{$accepted_date}}