DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-03-05 20:52:15 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fixes #13341 Clean up correct seats on license delete

Browse source 
Before this, we checked for the `id` collumn in the `license_seats` table, insteasd of
using `license_id` for this.

This way, we ensure that we only alter seats belonging to the correct license.
This commit is contained in:
Tobias Franzius 2023-07-20 13:26:42 +02:00
parent a19a508a80
commit 90a344af0b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/Http/Controllers/Licenses/LicensesController.php
View file

@ -207,7 +207,7 @@ class LicensesController extends Controller
if ($license->assigned_seats_count == 0) { if ($license->assigned_seats_count == 0) {
// Delete the license and the associated license seats // Delete the license and the associated license seats
DB::table('license_seats') DB::table('license_seats')
->where('id', $license->id) ->where('license_id', $license->id)
->update(['assigned_to' => null, 'asset_id' => null]); ->update(['assigned_to' => null, 'asset_id' => null]);
$licenseSeats = $license->licenseseats(); $licenseSeats = $license->licenseseats();