DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2024-12-25 05:34:06 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Make sure $user->item exists before trying to count on it

Browse source
This commit is contained in:
snipe 2019-12-11 14:43:46 -08:00
parent 4d38c44a93
commit 94ce8cad64
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/Http/Controllers/Users/UsersController.php
View file

@ -324,25 +324,25 @@ class UsersController extends Controller
->with('error', 'We would feel really bad if you deleted yourself, please reconsider.');
}
if (($assetsCount = $user->assets()->count()) > 0) {
if (($user->assets()) && (($assetsCount = $user->assets()->count()) > 0)) {
// Redirect to the user management page
return redirect()->route('users.index')
->with('error', 'This user still has ' . $assetsCount . ' assets associated with them.');
}
if (($licensesCount = $user->licenses()->count()) > 0) {
if (($user->licenses()) && (($licensesCount = $user->licenses()->count())) > 0) {
// Redirect to the user management page
return redirect()->route('users.index')
->with('error', 'This user still has ' . $licensesCount . ' licenses associated with them.');
}
if (($accessoriesCount = $user->accessories()->count()) > 0) {
if (($user->accessories()) && (($accessoriesCount = $user->accessories()->count()) > 0)) {
// Redirect to the user management page
return redirect()->route('users.index')
->with('error', 'This user still has ' . $accessoriesCount . ' accessories associated with them.');
}
if (($managedLocationsCount = $user->managedLocations()->count()) > 0) {
if (($user->managedLocations()) && (($managedLocationsCount = $user->managedLocations()->count())) > 0) {
// Redirect to the user management page
return redirect()->route('users.index')
->with('error', 'This user still has ' . $managedLocationsCount . ' locations that they manage.');