diff --git a/app/Http/Controllers/SavedReportsController.php b/app/Http/Controllers/ReportTemplatesController.php similarity index 66% rename from app/Http/Controllers/SavedReportsController.php rename to app/Http/Controllers/ReportTemplatesController.php index 487ded803a..5671cef244 100644 --- a/app/Http/Controllers/SavedReportsController.php +++ b/app/Http/Controllers/ReportTemplatesController.php @@ -3,18 +3,18 @@ namespace App\Http\Controllers; use App\Models\CustomField; -use App\Models\SavedReport; +use App\Models\ReportTemplate; use Illuminate\Http\Request; -class SavedReportsController extends Controller +class ReportTemplatesController extends Controller { public function store(Request $request) { $this->authorize('reports.view'); - $request->validate((new SavedReport)->getRules()); + $request->validate((new ReportTemplate)->getRules()); - $report = $request->user()->savedReports()->create([ + $report = $request->user()->reportTemplates()->create([ 'name' => $request->get('name'), 'options' => $request->except(['_token', 'name']), ]); @@ -24,19 +24,19 @@ class SavedReportsController extends Controller public function edit(Request $request, $reportId) { - $report = SavedReport::findOrFail($reportId); + $report = ReportTemplate::findOrFail($reportId); return view('reports/custom', [ 'customfields' => CustomField::get(), - 'savedReport' => $report, + 'reportTemplate' => $report, ]); } public function update(Request $request) { - $this->authorize('update',SavedReport::class); + $this->authorize('update',ReportTemplate::class); - if(is_null($reportid = SavedReport::find($request))) + if(is_null($reportid = ReportTemplate::find($request))) { return redirect()->route('reports/custom'); } @@ -44,7 +44,7 @@ class SavedReportsController extends Controller $request->validate()->report->id->getRules(); - $report = $request->user()->savedReports()->edit([ + $report = $request->user()->reportTemplates()->edit([ 'name' => $request->get('name'), 'options' => $request->except(['token','name']), ]); diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php index 9ff7108280..864e889653 100644 --- a/app/Http/Controllers/ReportsController.php +++ b/app/Http/Controllers/ReportsController.php @@ -11,7 +11,7 @@ use App\Models\CheckoutAcceptance; use App\Models\CustomField; use App\Models\Depreciation; use App\Models\License; -use App\Models\SavedReport; +use App\Models\ReportTemplate; use App\Models\Setting; use App\Notifications\CheckoutAssetNotification; use Carbon\Carbon; @@ -392,12 +392,12 @@ class ReportsController extends Controller { $this->authorize('reports.view'); $customfields = CustomField::get(); - $saved_reports = SavedReport::orderBy('name')->get(); + $report_templates = ReportTemplate::orderBy('name')->get(); return view('reports/custom', [ 'customfields' => $customfields, - 'saved_reports' => $saved_reports, - 'savedReport' => $saved_reports->find($request->input('report')) ?? new SavedReport, + 'report_templates' => $report_templates, + 'reportTemplate' => $report_templates->find($request->input('report')) ?? new ReportTemplate, ]); } diff --git a/app/Models/SavedReport.php b/app/Models/ReportTemplate.php similarity index 96% rename from app/Models/SavedReport.php rename to app/Models/ReportTemplate.php index 806c9dab99..6ea8dd95ab 100644 --- a/app/Models/SavedReport.php +++ b/app/Models/ReportTemplate.php @@ -6,7 +6,7 @@ use Illuminate\Database\Eloquent\Factories\HasFactory; use Illuminate\Database\Eloquent\Model; use Watson\Validating\ValidatingTrait; -class SavedReport extends Model +class ReportTemplate extends Model { use HasFactory; use ValidatingTrait; @@ -28,7 +28,7 @@ class SavedReport extends Model // @todo: add $rules protected $rules = [ - 'name' => 'required|unique:saved_reports,name', + 'name' => 'required|unique:report_templates,name', 'options' => 'array', ]; diff --git a/app/Models/User.php b/app/Models/User.php index 95713fb655..8355189b14 100644 --- a/app/Models/User.php +++ b/app/Models/User.php @@ -330,9 +330,9 @@ class User extends SnipeModel implements AuthenticatableContract, AuthorizableCo return $this->belongsToMany(\App\Models\License::class, 'license_seats', 'assigned_to', 'license_id')->withPivot('id'); } - public function savedReports(): HasMany + public function reportTemplates(): HasMany { - return $this->hasMany(SavedReport::class); + return $this->hasMany(ReportTemplate::class); } /** diff --git a/database/factories/SavedReportFactory.php b/database/factories/ReportTemplateFactory.php similarity index 88% rename from database/factories/SavedReportFactory.php rename to database/factories/ReportTemplateFactory.php index 72279bd3e5..1ece94e410 100644 --- a/database/factories/SavedReportFactory.php +++ b/database/factories/ReportTemplateFactory.php @@ -4,7 +4,7 @@ namespace Database\Factories; use Illuminate\Database\Eloquent\Factories\Factory; -class SavedReportFactory extends Factory +class ReportTemplateFactory extends Factory { /** * Define the model's default state. diff --git a/database/migrations/2023_08_23_232739_create_saved_reports_table.php b/database/migrations/2023_08_23_232739_create_report_templates_table.php similarity index 77% rename from database/migrations/2023_08_23_232739_create_saved_reports_table.php rename to database/migrations/2023_08_23_232739_create_report_templates_table.php index 2065880095..31615b6fe4 100644 --- a/database/migrations/2023_08_23_232739_create_saved_reports_table.php +++ b/database/migrations/2023_08_23_232739_create_report_templates_table.php @@ -4,7 +4,7 @@ use Illuminate\Database\Migrations\Migration; use Illuminate\Database\Schema\Blueprint; use Illuminate\Support\Facades\Schema; -class CreateSavedReportsTable extends Migration +class CreateReportTemplatesTable extends Migration { /** * Run the migrations. @@ -13,7 +13,7 @@ class CreateSavedReportsTable extends Migration */ public function up() { - Schema::create('saved_reports', function (Blueprint $table) { + Schema::create('report_templates', function (Blueprint $table) { $table->id(); $table->integer('user_id')->nullable(); $table->string('name'); @@ -30,6 +30,6 @@ class CreateSavedReportsTable extends Migration */ public function down() { - Schema::dropIfExists('saved_reports'); + Schema::dropIfExists('report_templates'); } } diff --git a/resources/views/reports/custom.blade.php b/resources/views/reports/custom.blade.php index 29a9511bd9..016020a508 100644 --- a/resources/views/reports/custom.blade.php +++ b/resources/views/reports/custom.blade.php @@ -28,31 +28,31 @@