DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2024-11-12 16:44:08 -08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Simplify assertions

Browse source
This commit is contained in:
Marcus Moore 2024-08-21 17:00:32 -07:00
parent 1d89759706
commit a2246b9645
No known key found for this signature in database
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tests/Feature/AssetModels/Ui/UpdateAssetModelsTest.php
View file

@ -90,13 +90,10 @@ class UpdateAssetModelsTest extends TestCase
], ],
]); ]);
$this->assertEquals( $potentiallyChangedDefaultValues = $assetModel->defaultValues->pluck('pivot.default_value');
2, $this->assertCount(2, $potentiallyChangedDefaultValues);
$assetModel->fresh()->defaultValues->filter(function (CustomField $field) { $this->assertContains('first default value', $potentiallyChangedDefaultValues);
return in_array($field->pivot->default_value, ['first default value', 'second default value']); $this->assertContains('second default value', $potentiallyChangedDefaultValues);
})->count(),
'Default field values were changed unexpectedly.'
);
} }
public function test_default_values_can_be_updated() public function test_default_values_can_be_updated()
@ -129,7 +126,6 @@ class UpdateAssetModelsTest extends TestCase
]); ]);
$potentiallyChangedDefaultValues = $assetModel->defaultValues->pluck('pivot.default_value'); $potentiallyChangedDefaultValues = $assetModel->defaultValues->pluck('pivot.default_value');
$this->assertCount(2, $potentiallyChangedDefaultValues); $this->assertCount(2, $potentiallyChangedDefaultValues);
$this->assertContains('first changed value', $potentiallyChangedDefaultValues); $this->assertContains('first changed value', $potentiallyChangedDefaultValues);
$this->assertContains('second changed value', $potentiallyChangedDefaultValues); $this->assertContains('second changed value', $potentiallyChangedDefaultValues);