DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2024-12-25 05:34:06 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Update tests

Browse source 
https://masteringlaravel.io/daily/2024-02-09-watch-out-for-this-when-testing-artisan-commands
This commit is contained in:
Marcus Moore 2024-08-13 12:16:08 -07:00
parent 321839e074
commit ae0a6d66f3
No known key found for this signature in database
1 changed files with 6 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
tests/Feature/Console/FixupAssignedToAssignedTypeTest.php
View file

@ -10,7 +10,6 @@ class FixupAssignedToAssignedTypeTest extends TestCase
{ {
public function testEmptyAssignedType() public function testEmptyAssignedType()
{ {
$this->markTestIncomplete();
$asset = Asset::factory()->create(); $asset = Asset::factory()->create();
$user = User::factory()->create(); $user = User::factory()->create();
$admin = User::factory()->admin()->create(); $admin = User::factory()->admin()->create();
@ -18,15 +17,10 @@ class FixupAssignedToAssignedTypeTest extends TestCase
$asset->checkOut($user, $admin); $asset->checkOut($user, $admin);
$asset->assigned_type=null; //blank out the assigned type $asset->assigned_type=null; //blank out the assigned type
$asset->save(); $asset->save();
print "Okay we set everything up~!!!\n";
$output = $this->artisan('snipeit:assigned-to-fixup --debug')->assertExitCode(0); $this->artisan('snipeit:assigned-to-fixup --debug')->assertExitCode(0);
print "artisan ran!\n";
dump($output); $this->assertEquals(User::class, $asset->fresh()->assigned_type);
$asset = Asset::find($asset->id);
print "\n we refreshed the asset?";
dump($asset);
$this->assertEquals(User::class, $asset->assigned_type);
} }
public function testInvalidAssignedTo() public function testInvalidAssignedTo()
@ -37,21 +31,15 @@ class FixupAssignedToAssignedTypeTest extends TestCase
$admin = User::factory()->admin()->create(); $admin = User::factory()->admin()->create();
$asset->checkOut($user, $admin); $asset->checkOut($user, $admin);
// $asset->checkIn($user, $admin); //no such method btw
$asset->assigned_type=null; $asset->assigned_type=null;
$asset->assigned_to=null; $asset->assigned_to=null;
$asset->saveOrFail(); //*should* generate a 'checkin'? $asset->saveOrFail(); //*should* generate a 'checkin'?
$asset->assigned_to=$user->id; //incorrectly mark asset as partially checked-out $asset->assigned_to=$user->id; //incorrectly mark asset as partially checked-out
$asset->saveOrFail(); $asset->saveOrFail();
print "Okay we set everything up for test TWO~!!!\n";
$output = $this->artisan('snipeit:assigned-to-fixup --debug')->assertExitCode(0); $this->artisan('snipeit:assigned-to-fixup --debug')->assertExitCode(0);
print "artisan ran TWO!\n";
dump($output); $this->assertNull($asset->fresh()->assigned_to);
$asset = Asset::find($asset->id);
print "\n we refreshed the asset?";
dump($asset);
$this->assertNull($asset->assigned_to);
} }
} }