mirror of
https://github.com/snipe/snipe-it.git
synced 2024-12-25 13:44:06 -08:00
Declare variables only if license is found
This commit is contained in:
parent
4a5426f959
commit
ae53609b1b
|
@ -234,18 +234,19 @@ class LicensesController extends Controller
|
||||||
public function show($licenseId = null)
|
public function show($licenseId = null)
|
||||||
{
|
{
|
||||||
$license = License::with('assignedusers')->find($licenseId);
|
$license = License::with('assignedusers')->find($licenseId);
|
||||||
$users_count = User::where('autoassign_licenses', '1')->count();
|
|
||||||
$total_seats_count = $license->totalSeatsByLicenseID();
|
|
||||||
$available_seats_count = $license->availCount()->count();
|
|
||||||
$checkedout_seats_count = ($total_seats_count - $available_seats_count);
|
|
||||||
|
|
||||||
\Log::debug('Total: '.$total_seats_count);
|
|
||||||
\Log::debug('Users: '.$users_count);
|
|
||||||
\Log::debug('Available: '.$available_seats_count);
|
|
||||||
\Log::debug('Checkedout: '.$checkedout_seats_count);
|
|
||||||
|
|
||||||
|
|
||||||
if ($license) {
|
if ($license) {
|
||||||
|
$users_count = User::where('autoassign_licenses', '1')->count();
|
||||||
|
$total_seats_count = $license->totalSeatsByLicenseID();
|
||||||
|
$available_seats_count = $license->availCount()->count();
|
||||||
|
$checkedout_seats_count = ($total_seats_count - $available_seats_count);
|
||||||
|
|
||||||
|
\Log::debug('Total: '.$total_seats_count);
|
||||||
|
\Log::debug('Users: '.$users_count);
|
||||||
|
\Log::debug('Available: '.$available_seats_count);
|
||||||
|
\Log::debug('Checkedout: '.$checkedout_seats_count);
|
||||||
|
|
||||||
|
|
||||||
$this->authorize('view', $license);
|
$this->authorize('view', $license);
|
||||||
return view('licenses.view', compact('license'))
|
return view('licenses.view', compact('license'))
|
||||||
->with('users_count', $users_count)
|
->with('users_count', $users_count)
|
||||||
|
@ -254,7 +255,7 @@ class LicensesController extends Controller
|
||||||
->with('checkedout_seats_count', $checkedout_seats_count);
|
->with('checkedout_seats_count', $checkedout_seats_count);
|
||||||
}
|
}
|
||||||
|
|
||||||
return redirect()->route('licenses.view')
|
return redirect()->route('licenses.index')
|
||||||
->with('error', trans('admin/licenses/message.does_not_exist'));
|
->with('error', trans('admin/licenses/message.does_not_exist'));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue