From b06501dd0288938e5533fd7950603a837678a558 Mon Sep 17 00:00:00 2001
From: Marcus Moore <contact@marcusmoore.io>
Date: Mon, 5 Aug 2024 16:02:59 -0700
Subject: [PATCH] Add assertions

---
 .../Feature/Users/Ui/BulkDeleteUsersTest.php  | 20 +++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/tests/Feature/Users/Ui/BulkDeleteUsersTest.php b/tests/Feature/Users/Ui/BulkDeleteUsersTest.php
index 6b4621daf9..be5af79e01 100644
--- a/tests/Feature/Users/Ui/BulkDeleteUsersTest.php
+++ b/tests/Feature/Users/Ui/BulkDeleteUsersTest.php
@@ -48,7 +48,7 @@ class BulkDeleteUsersTest extends TestCase
         ])->assertSessionHas('error')->assertRedirect();
     }
 
-    public function testAccessoryCheckinsAreProperlyLogged()
+    public function testAccessoriesCanBeBulkCheckedIn()
     {
         [$accessoryA, $accessoryB] = Accessory::factory()->count(2)->create();
         [$userA, $userB, $userC] = User::factory()->count(3)->create();
@@ -57,6 +57,10 @@ class BulkDeleteUsersTest extends TestCase
         $this->attachAccessoryToUsers($accessoryA, [$userA, $userB, $userC]);
         $this->attachAccessoryToUsers($accessoryB, [$userA, $userB]);
 
+        $this->assertTrue($userA->accessories->isNotEmpty());
+        $this->assertTrue($userB->accessories->isNotEmpty());
+        $this->assertTrue($userC->accessories->isNotEmpty());
+
         $this->actingAs(User::factory()->editUsers()->create())
             ->post(route('users/bulksave'), [
                 'ids' => [
@@ -67,6 +71,10 @@ class BulkDeleteUsersTest extends TestCase
             ])
             ->assertRedirect();
 
+        $this->assertTrue($userA->fresh()->accessories->isEmpty());
+        $this->assertTrue($userB->fresh()->accessories->isNotEmpty());
+        $this->assertTrue($userC->fresh()->accessories->isEmpty());
+
         // These assertions check against a bug where the wrong value from
         // accessories_users was being populated in action_logs.item_id.
         $this->assertActionLogCheckInEntryFor($userA, $accessoryA);
@@ -74,7 +82,7 @@ class BulkDeleteUsersTest extends TestCase
         $this->assertActionLogCheckInEntryFor($userC, $accessoryA);
     }
 
-    public function testConsumableCheckinsAreProperlyLogged()
+    public function testConsumablesCanBeBulkCheckedIn()
     {
         [$consumableA, $consumableB] = Consumable::factory()->count(2)->create();
         [$userA, $userB, $userC] = User::factory()->count(3)->create();
@@ -83,6 +91,10 @@ class BulkDeleteUsersTest extends TestCase
         $this->attachConsumableToUsers($consumableA, [$userA, $userB, $userC]);
         $this->attachConsumableToUsers($consumableB, [$userA, $userB]);
 
+        $this->assertTrue($userA->consumables->isNotEmpty());
+        $this->assertTrue($userB->consumables->isNotEmpty());
+        $this->assertTrue($userC->consumables->isNotEmpty());
+
         $this->actingAs(User::factory()->editUsers()->create())
             ->post(route('users/bulksave'), [
                 'ids' => [
@@ -93,6 +105,10 @@ class BulkDeleteUsersTest extends TestCase
             ])
             ->assertRedirect();
 
+        $this->assertTrue($userA->fresh()->consumables->isEmpty());
+        $this->assertTrue($userB->fresh()->consumables->isNotEmpty());
+        $this->assertTrue($userC->fresh()->consumables->isEmpty());
+
         // These assertions check against a bug where the wrong value from
         // consumables_users was being populated in action_logs.item_id.
         $this->assertActionLogCheckInEntryFor($userA, $consumableA);