DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2024-12-25 05:34:06 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add component unit test and unify some validation.

Browse source
This commit is contained in:
Daniel Meltzer 2020-04-30 09:50:12 -04:00
parent 68224757f4
commit b28a4f3108
No known key found for this signature in database
GPG key ID: 91C5C7B09A5B1CA0
2 changed files with 107 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
app/Models/Component.php
View file

@ -20,17 +20,18 @@ class Component extends SnipeModel
protected $dates = ['deleted_at', 'purchase_date'];
protected $table = 'components';
/**
* Category validation rules
*/
public $rules = array(
'name' => 'required|min:3|max:255',
'qty' => 'required|integer|min:1',
'category_id' => 'required|integer',
'company_id' => 'integer|nullable',
'name' => 'required|min:3|max:255',
'qty' => 'required|integer|min:1',
'category_id' => 'required|integer|exists:categories,id',
'company_id' => 'integer|nullable',
'min_amt' => 'integer|min:0|nullable',
'purchase_date' => 'date|nullable',
'purchase_cost' => 'numeric|nullable',
'purchase_cost' => 'numeric|nullable',
);
/**

100
tests/unit/ComponentTest.php Normal file
View file

@ -0,0 +1,100 @@
<?php
use App\Models\Category;
use App\Models\Company;
use App\Models\Component;
use App\Models\Location;
use Illuminate\Foundation\Testing\DatabaseMigrations;
use Illuminate\Foundation\Testing\DatabaseTransactions;
use Illuminate\Foundation\Testing\WithoutMiddleware;
use Illuminate\Support\Facades\Hash;
class ComponentTest extends BaseTest
{
/**
* @var \UnitTester
*/
protected $tester;
public function testFailsEmptyValidation()
{
// An Component requires a name, a qty, and a category_id.
$a = Component::create();
$this->assertFalse($a->isValid());
$fields = [
'name' => 'name',
'qty' => 'qty',
'category_id' => 'category id'
];
$errors = $a->getErrors();
foreach ($fields as $field => $fieldTitle) {
$this->assertEquals($errors->get($field)[0], "The ${fieldTitle} field is required.");
}
}
public function testFailsMinValidation()
{
// An Component name has a min length of 3
// An Component has a min qty of 1
// An Component has a min amount of 0
$a = factory(Component::class)->make([
'name' => 'a',
'qty' => 0,
'min_amt' => -1
]);
$fields = [
'name' => 'name',
'qty' => 'qty',
'min_amt' => 'min amt'
];
$this->assertFalse($a->isValid());
$errors = $a->getErrors();
foreach ($fields as $field => $fieldTitle) {
$this->assertStringContainsString("The ${fieldTitle} must be at least", $errors->get($field)[0]);
}
}
public function testCategoryIdMustExist()
{
$category = $this->createValidCategory('component-hdd-category',
['category_type' => 'component']);
$component = factory(Component::class)
->states('ssd-crucial240')
->make(['category_id' => $category->id]);
$this->createValidManufacturer('apple');
$component->save();
$this->assertTrue($component->isValid());
$newId = $category->id + 1;
$component = factory(Component::class)->states('ssd-crucial240')->make(['category_id' => $newId]);
$component->save();
$this->assertFalse($component->isValid());
$this->assertStringContainsString("The selected category id is invalid.", $component->getErrors()->get('category_id')[0]);
}
public function testAnComponentBelongsToACompany()
{
$component = factory(Component::class)
->create(['company_id' => factory(Company::class)->create()->id]);
$this->assertInstanceOf(Company::class, $component->company);
}
public function testAnComponentHasALocation()
{
$component = factory(Component::class)
->create(['location_id' => factory(Location::class)->create()->id]);
$this->assertInstanceOf(Location::class, $component->location);
}
public function testAnComponentBelongsToACategory()
{
$component = factory(Component::class)->states('ssd-crucial240')
->create([
'category_id' => factory(Category::class)
->states('component-hdd-category')
->create(['category_type' => 'component'])->id
]);
$this->assertInstanceOf(Category::class, $component->category);
$this->assertEquals('component', $component->category->category_type);
}
}