Merge pull request #9947 from snipe/fixes/apply_v6_currency_formatter

Fixed #9909  and #9714 - applies v6 currency formatter to v5 [ch16628]
This commit is contained in:
snipe 2021-08-17 22:00:39 -07:00 committed by GitHub
commit b5e69d6678
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 13 additions and 7 deletions

View file

@ -46,7 +46,10 @@ class Helper
public static function formatCurrencyOutput($cost)
{
if (is_numeric($cost)) {
return number_format($cost, 2, '.', '');
if (Setting::getSettings()->digit_separator=='1.234,56') {
return number_format($cost, 2, ',', '.');
}
return number_format($cost, 2, '.', ',');
}
// It's already been parsed.
return $cost;

View file

@ -146,7 +146,6 @@ class AssetPresenter extends Presenter
"searchable" => true,
"sortable" => true,
"title" => trans('general.purchase_cost'),
"formatter" => 'numberWithCommas',
"footerFormatter" => 'sumFormatter',
], [
"field" => "order_number",

View file

@ -14,7 +14,7 @@ class AddDigitSeparatorToSettings extends Migration
public function up()
{
Schema::table('settings', function (Blueprint $table) {
$table->char('digit_separator')->nullable()->default('1234.56');
$table->char('digit_separator')->nullable()->default('1,234.56');
});
}

View file

@ -414,7 +414,7 @@ Form::macro('time_display_format', function ($name = "time_display_format", $sel
Form::macro('digit_separator', function ($name = "digit_separator", $selected = null, $class = null) {
$formats = [
'1234.56',
'1,234.56',
'1.234,56',
];

View file

@ -608,9 +608,13 @@
function numberWithCommas(value) {
if ((value) && ("{{$snipeSettings->digit_separator}}" == "1.234,56")){
var parts = value.toString().split(".");
parts[0] = parts[0].replace(/\B(?=(\d{3})+(?!\d))/g, ".");
return parts.join(",");
var parts = value.toString().split(".");
parts[0] = parts[0].replace(/\B(?=(\d{3})+(?!\d))/g, ".");
return parts.join(",");
} else {
var parts = value.toString().split(",");
parts[0] = parts[0].replace(/\B(?=(\d{3})+(?!\d))/g, ",");
return parts.join(".");
}
return value
}