From b813dcd9d0905045482c65251205c9cba91e0ded Mon Sep 17 00:00:00 2001
From: akemidx <kojotek.dx@gmail.com>
Date: Wed, 25 Sep 2024 18:54:30 -0400
Subject: [PATCH] requested changes from github

---
 app/Http/Controllers/Api/NotesController.php | 14 +++++++++++---
 app/Models/Note.php                          | 17 -----------------
 2 files changed, 11 insertions(+), 20 deletions(-)
 delete mode 100644 app/Models/Note.php

diff --git a/app/Http/Controllers/Api/NotesController.php b/app/Http/Controllers/Api/NotesController.php
index 37527fb993..f1f8f62144 100644
--- a/app/Http/Controllers/Api/NotesController.php
+++ b/app/Http/Controllers/Api/NotesController.php
@@ -8,16 +8,24 @@ use App\Http\Controllers\Controller;
 use App\Models\Asset;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
+use Illuminate\Validation\Rule;
 
 class NotesController extends Controller
 {
     public function store(Request $request)
     {
+        $validated = $request->validate([
+            'note' => 'required|string|max:500',
+            'type' => [
+                'required',
+                Rule::in(['asset']),
+            ],
+        ]);
+
         $item = Asset::findOrFail($request->input("id"));
         $this->authorize('update', $item);
-
-        $validated = $request->validate([
-            'note' => 'required|string|max:500']);
+        // This can be made dynamic by using $request->input('type') to determine which model type to add the note to.
+        // For now, we are only placing this on Assets
 
         event(new NoteAdded($item, Auth::user(), $validated['note']));
 
diff --git a/app/Models/Note.php b/app/Models/Note.php
deleted file mode 100644
index a7c35887b7..0000000000
--- a/app/Models/Note.php
+++ /dev/null
@@ -1,17 +0,0 @@
-<?php
-
-namespace App\Models;
-
-use Illuminate\Database\Eloquent\Model;
-use Illuminate\Database\Eloquent\Relations\MorphTo;
-
-class Note extends Model
-{
-    /**
-     * Get the parent item of a comment
-     */
-    public function commentable(): MorphTo
-    {
-        return $this->morphTo();
-    }
-}
\ No newline at end of file