diff --git a/app/Http/Controllers/ViewAssetsController.php b/app/Http/Controllers/ViewAssetsController.php index 6febfd5f8e..acbe21b929 100755 --- a/app/Http/Controllers/ViewAssetsController.php +++ b/app/Http/Controllers/ViewAssetsController.php @@ -379,6 +379,7 @@ class ViewAssetsController extends Controller } $logaction->target_id = $findlog->target_id; + $logaction->target_type = User::class; $logaction->note = e(Input::get('note')); $logaction->updated_at = date("Y-m-d H:i:s"); diff --git a/database/migrations/2016_11_24_160405_add_missing_target_type_to_logs_table.php b/database/migrations/2016_11_24_160405_add_missing_target_type_to_logs_table.php new file mode 100644 index 0000000000..c71d3b4e30 --- /dev/null +++ b/database/migrations/2016_11_24_160405_add_missing_target_type_to_logs_table.php @@ -0,0 +1,32 @@ +where('target_type', null)->where(function($query) { + $query->where('action_type', 'accepted') + ->orWhere('action_type', 'declined'); + })->update(['target_type'=> 'App\Models\User']); + } + + /** + * Reverse the migrations. + * + * @return void + */ + public function down() + { + // Nothing to do. + } +} diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index 2519168f21..27a4195740 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -212,7 +212,7 @@ @endif - @if ($asset->supplier_id) + @if ($asset->supplier) {{ trans('admin/hardware/form.supplier') }} @@ -615,7 +615,12 @@ {{ $log->target->showAssetName() }} @endif @elseif (($log->action_type=='accepted') || ($log->action_type=='declined')) + {{-- On a declined log, the asset isn't assigned to anyone when we look this up. --}} + @if ($log->item->assigneduser) {{ $log->item->assigneduser->fullName() }} + @else + Unknown + @endif @else Deleted User