mirror of
https://github.com/snipe/snipe-it.git
synced 2025-03-05 20:52:15 -08:00
Properly sort the results based on non-asset fields
Signed-off-by: snipe <snipe@snipe.net>
This commit is contained in:
parent
dd3b2da670
commit
ba680126bc
|
@ -49,15 +49,87 @@ class BulkAssetsController extends Controller
|
||||||
return redirect()->back()->with('error', trans('admin/hardware/message.update.no_assets_selected'));
|
return redirect()->back()->with('error', trans('admin/hardware/message.update.no_assets_selected'));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
$asset_ids = $request->input('ids');
|
||||||
|
|
||||||
// Figure out where we need to send the user after the update is complete, and store that in the session
|
// Figure out where we need to send the user after the update is complete, and store that in the session
|
||||||
$bulk_back_url = request()->headers->get('referer');
|
$bulk_back_url = request()->headers->get('referer');
|
||||||
session(['bulk_back_url' => $bulk_back_url]);
|
session(['bulk_back_url' => $bulk_back_url]);
|
||||||
|
|
||||||
|
$allowed_columns = [
|
||||||
|
'id',
|
||||||
|
'name',
|
||||||
|
'asset_tag',
|
||||||
|
'serial',
|
||||||
|
'model_number',
|
||||||
|
'last_checkout',
|
||||||
|
'notes',
|
||||||
|
'expected_checkin',
|
||||||
|
'order_number',
|
||||||
|
'image',
|
||||||
|
'assigned_to',
|
||||||
|
'created_at',
|
||||||
|
'updated_at',
|
||||||
|
'purchase_date',
|
||||||
|
'purchase_cost',
|
||||||
|
'last_audit_date',
|
||||||
|
'next_audit_date',
|
||||||
|
'warranty_months',
|
||||||
|
'checkout_counter',
|
||||||
|
'checkin_counter',
|
||||||
|
'requests_counter',
|
||||||
|
'byod',
|
||||||
|
'asset_eol_date',
|
||||||
|
];
|
||||||
|
|
||||||
$asset_ids = $request->input('ids');
|
|
||||||
// Using the 'short-ternary' A/K/A "Elvis operator" '?:' here because ->input() might return an empty string
|
/**
|
||||||
list($sortname,$sortdir) = explode(" ",$request->input('sort') ?: 'id ASC');
|
* Make sure the column is allowed, and if it's a custom field, make sure we strip the custom_fields. prefix
|
||||||
$assets = Asset::with('assignedTo', 'location', 'model')->whereIn('id', $asset_ids)->orderBy($sortname, $sortdir)->get();
|
*/
|
||||||
|
$order = $request->input('order') === 'asc' ? 'asc' : 'desc';
|
||||||
|
$sort_override = str_replace('custom_fields.', '', $request->input('sort'));
|
||||||
|
|
||||||
|
// This handles all of the pivot sorting below (versus the assets.* fields in the allowed_columns array)
|
||||||
|
$column_sort = in_array($sort_override, $allowed_columns) ? $sort_override : 'assets.id';
|
||||||
|
|
||||||
|
$assets = Asset::with('assignedTo', 'location', 'model')->whereIn('assets.id', $asset_ids);
|
||||||
|
|
||||||
|
switch ($sort_override) {
|
||||||
|
case 'model':
|
||||||
|
$assets->OrderModels($order);
|
||||||
|
break;
|
||||||
|
case 'model_number':
|
||||||
|
$assets->OrderModelNumber($order);
|
||||||
|
break;
|
||||||
|
case 'category':
|
||||||
|
$assets->OrderCategory($order);
|
||||||
|
break;
|
||||||
|
case 'manufacturer':
|
||||||
|
$assets->OrderManufacturer($order);
|
||||||
|
break;
|
||||||
|
case 'company':
|
||||||
|
$assets->OrderCompany($order);
|
||||||
|
break;
|
||||||
|
case 'location':
|
||||||
|
$assets->OrderLocation($order);
|
||||||
|
case 'rtd_location':
|
||||||
|
$assets->OrderRtdLocation($order);
|
||||||
|
break;
|
||||||
|
case 'status_label':
|
||||||
|
$assets->OrderStatus($order);
|
||||||
|
break;
|
||||||
|
case 'supplier':
|
||||||
|
$assets->OrderSupplier($order);
|
||||||
|
break;
|
||||||
|
case 'assigned_to':
|
||||||
|
$assets->OrderAssigned($order);
|
||||||
|
break;
|
||||||
|
default:
|
||||||
|
$assets->orderBy($column_sort, $order);
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
|
\Log::debug($assets->toSql());
|
||||||
|
$assets = $assets->get();
|
||||||
|
|
||||||
$models = $assets->unique('model_id');
|
$models = $assets->unique('model_id');
|
||||||
$modelNames = [];
|
$modelNames = [];
|
||||||
|
|
Loading…
Reference in a new issue