From ba70e5b0533534d7d8f264d01bdfffc46655f135 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 30 Aug 2016 07:34:33 -0700 Subject: [PATCH] A little demo-proofing of the maintenances page --- app/Http/Controllers/AssetMaintenancesController.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/app/Http/Controllers/AssetMaintenancesController.php b/app/Http/Controllers/AssetMaintenancesController.php index e265bbe935..b7bdb81bbb 100644 --- a/app/Http/Controllers/AssetMaintenancesController.php +++ b/app/Http/Controllers/AssetMaintenancesController.php @@ -122,20 +122,18 @@ class AssetMaintenancesController extends Controller $actions = ''; - if (($maintenance->cost) && ($maintenance->asset->assetloc) && ($maintenance->asset->assetloc->currency!='')) { + if (($maintenance->cost) && (isset($maintenance->asset)) && ($maintenance->asset->assetloc) && ($maintenance->asset->assetloc->currency!='')) { $maintenance_cost = $maintenance->asset->assetloc->currency.$maintenance->cost; } else { $maintenance_cost = $settings->default_currency.$maintenance->cost; } - - $company = $maintenance->asset->company; - + $rows[] = array( 'id' => $maintenance->id, - 'asset_name' => (string)link_to('/hardware/'.$maintenance->asset->id.'/view', $maintenance->asset->showAssetName()) , + 'asset_name' => ($maintenance->asset) ? (string)link_to('/hardware/'.$maintenance->asset->id.'/view', $maintenance->asset->showAssetName()) : 'Deleted Asset' , 'title' => $maintenance->title, 'notes' => $maintenance->notes, - 'supplier' => $maintenance->supplier->name, + 'supplier' => ($maintenance->supplier) ? (string)link_to('/admin/settings/suppliers/'.$maintenance->supplier->id.'/view', $maintenance->supplier->name) : 'Deleted Supplier', 'cost' => $maintenance_cost, 'asset_maintenance_type' => e($maintenance->asset_maintenance_type), 'start_date' => $maintenance->start_date, @@ -143,7 +141,7 @@ class AssetMaintenancesController extends Controller 'completion_date' => $maintenance->completion_date, 'user_id' => ($maintenance->admin) ? (string)link_to('/admin/users/'.$maintenance->admin->id.'/view', $maintenance->admin->fullName()) : '', 'actions' => $actions, - 'companyName' => is_null($company) ? '' : $company->name + 'companyName' => ($maintenance->asset) ? $maintenance->asset->company->name : '' ); }