DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-02-21 03:15:45 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Improve readability by extracting additional helpers

Browse source
This commit is contained in:
Marcus Moore 2024-02-27 17:44:19 -08:00
parent bf32ab177f
commit bd4d3aa52b
No known key found for this signature in database
1 changed files with 22 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
tests/Feature/Notifications/Webhooks/SlackNotificationsUponCheckinTest.php
View file

@ -56,13 +56,7 @@ class SlackNotificationsUponCheckinTest extends TestCase
User::factory()->create(),
);
Notification::assertSentTo(
new AnonymousNotifiable,
CheckinAccessoryNotification::class,
function ($notification, $channels, $notifiable) {
return $notifiable->routes['slack'] === Setting::getSettings()->webhook_endpoint;
}
);
$this->assertSlackNotificationSent(CheckinAccessoryNotification::class);
}
public function testAccessoryCheckinDoesNotSendSlackNotificationWhenSettingDisabled()
@ -74,7 +68,7 @@ class SlackNotificationsUponCheckinTest extends TestCase
User::factory()->create(),
);
Notification::assertNotSentTo(new AnonymousNotifiable, CheckinAccessoryNotification::class);
$this->assertNoSlackNotificationSent(CheckinAccessoryNotification::class);
}
/** @dataProvider assetCheckoutTargets */
@ -87,13 +81,7 @@ class SlackNotificationsUponCheckinTest extends TestCase
$checkoutTarget(),
);
Notification::assertSentTo(
new AnonymousNotifiable,
CheckinAssetNotification::class,
function ($notification, $channels, $notifiable) {
return $notifiable->routes['slack'] === Setting::getSettings()->webhook_endpoint;
}
);
$this->assertSlackNotificationSent(CheckinAssetNotification::class);
}
/** @dataProvider assetCheckoutTargets */
@ -106,7 +94,7 @@ class SlackNotificationsUponCheckinTest extends TestCase
$checkoutTarget(),
);
Notification::assertNotSentTo(new AnonymousNotifiable, CheckinAssetNotification::class);
$this->assertNoSlackNotificationSent(CheckinAssetNotification::class);
}
public function testComponentCheckinDoesNotSendSlackNotification()
@ -141,13 +129,7 @@ class SlackNotificationsUponCheckinTest extends TestCase
$checkoutTarget(),
);
Notification::assertSentTo(
new AnonymousNotifiable,
CheckinLicenseSeatNotification::class,
function ($notification, $channels, $notifiable) {
return $notifiable->routes['slack'] === Setting::getSettings()->webhook_endpoint;
}
);
$this->assertSlackNotificationSent(CheckinLicenseSeatNotification::class);
}
/** @dataProvider licenseCheckoutTargets */
@ -160,7 +142,7 @@ class SlackNotificationsUponCheckinTest extends TestCase
$checkoutTarget(),
);
Notification::assertNotSentTo(new AnonymousNotifiable, CheckinLicenseSeatNotification::class);
$this->assertNoSlackNotificationSent(CheckinLicenseSeatNotification::class);
}
private function fireCheckInEvent(Model $checkoutable, Model $target)
@ -172,4 +154,20 @@ class SlackNotificationsUponCheckinTest extends TestCase
''
));
}
private function assertSlackNotificationSent(string $notificationClass)
{
Notification::assertSentTo(
new AnonymousNotifiable,
$notificationClass,
function ($notification, $channels, $notifiable) {
return $notifiable->routes['slack'] === Setting::getSettings()->webhook_endpoint;
}
);
}
private function assertNoSlackNotificationSent(string $notificationClass)
{
Notification::assertNotSentTo(new AnonymousNotifiable, CheckinAccessoryNotification::class);
}
}