DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-03-05 20:52:15 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add a few typehints

Browse source
This commit is contained in:
Marcus Moore 2023-12-11 11:27:56 -08:00
parent 4a0bb31866
commit bd86c5430c
No known key found for this signature in database
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/Models/SavedReport.php
View file

@ -27,7 +27,7 @@ class SavedReport extends Model
//we will need a bit to catch and store the name of the report. //we will need a bit to catch and store the name of the report.
//for now the blip above is creating the name, but can be confusing if multiple are made at once //for now the blip above is creating the name, but can be confusing if multiple are made at once
public function checkmarkValue($property): string public function checkmarkValue(string $property): string
{ {
// Assuming we're using the null object pattern, // Assuming we're using the null object pattern,
// return the default value if the object is not saved yet. // return the default value if the object is not saved yet.
@ -40,9 +40,10 @@ class SavedReport extends Model
return $this->options[$property] ?? '0'; return $this->options[$property] ?? '0';
} }
public function radioValue($property, $value, $return) public function radioValue(string $property, $value, $return)
{ {
// @todo: this method feels more like "radioShouldBeChecked" or something... // @todo: this method feels more like "radioShouldBeChecked" or something...
// @todo: improve the variable names...
// if (array_has($this->options, $property) && $this->options[$property] === $value) { // if (array_has($this->options, $property) && $this->options[$property] === $value) {
// return $return; // return $return;
@ -52,12 +53,12 @@ class SavedReport extends Model
return null; return null;
} }
public function selectValue($property) public function selectValue(string $property)
{ {
return $this->options[$property] ?? null; return $this->options[$property] ?? null;
} }
public function selectValues($property) public function selectValues(string $property)
{ {
if (!isset($this->options[$property])) { if (!isset($this->options[$property])) {
return null; return null;
@ -70,7 +71,7 @@ class SavedReport extends Model
return $this->options[$property]; return $this->options[$property];
} }
public function textValue($property): string public function textValue(string $property): string
{ {
// Assuming we're using the null object pattern, // Assuming we're using the null object pattern,
// return the default value if the object is not saved yet. // return the default value if the object is not saved yet.