DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-02-21 03:15:45 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Improve readability by extracting fireCheckInEvent method

Browse source
This commit is contained in:
Marcus Moore 2024-02-27 17:37:07 -08:00
parent 2ea883aa15
commit bf32ab177f
No known key found for this signature in database
1 changed files with 25 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
tests/Feature/Notifications/Webhooks/SlackNotificationsUponCheckinTest.php
View file

@ -13,6 +13,7 @@ use App\Models\User;
use App\Notifications\CheckinAccessoryNotification; use App\Notifications\CheckinAccessoryNotification;
use App\Notifications\CheckinAssetNotification; use App\Notifications\CheckinAssetNotification;
use App\Notifications\CheckinLicenseSeatNotification; use App\Notifications\CheckinLicenseSeatNotification;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Notifications\AnonymousNotifiable; use Illuminate\Notifications\AnonymousNotifiable;
use Illuminate\Support\Facades\Notification; use Illuminate\Support\Facades\Notification;
use Tests\Support\InteractsWithSettings; use Tests\Support\InteractsWithSettings;
@ -50,12 +51,10 @@ class SlackNotificationsUponCheckinTest extends TestCase
{ {
$this->settings->enableSlackWebhook(); $this->settings->enableSlackWebhook();
event(new CheckoutableCheckedIn( $this->fireCheckInEvent(
Accessory::factory()->appleBtKeyboard()->create(), Accessory::factory()->appleBtKeyboard()->create(),
User::factory()->create(), User::factory()->create(),
User::factory()->superuser()->create(), );
''
));
Notification::assertSentTo( Notification::assertSentTo(
new AnonymousNotifiable, new AnonymousNotifiable,
@ -70,12 +69,10 @@ class SlackNotificationsUponCheckinTest extends TestCase
{ {
$this->settings->disableSlackWebhook(); $this->settings->disableSlackWebhook();
event(new CheckoutableCheckedIn( $this->fireCheckInEvent(
Accessory::factory()->appleBtKeyboard()->create(), Accessory::factory()->appleBtKeyboard()->create(),
User::factory()->create(), User::factory()->create(),
User::factory()->superuser()->create(), );
''
));
Notification::assertNotSentTo(new AnonymousNotifiable, CheckinAccessoryNotification::class); Notification::assertNotSentTo(new AnonymousNotifiable, CheckinAccessoryNotification::class);
} }
@ -85,12 +82,10 @@ class SlackNotificationsUponCheckinTest extends TestCase
{ {
$this->settings->enableSlackWebhook(); $this->settings->enableSlackWebhook();
event(new CheckoutableCheckedIn( $this->fireCheckInEvent(
Asset::factory()->laptopMbp()->create(), Asset::factory()->laptopMbp()->create(),
$checkoutTarget(), $checkoutTarget(),
User::factory()->superuser()->create(), );
''
));
Notification::assertSentTo( Notification::assertSentTo(
new AnonymousNotifiable, new AnonymousNotifiable,
@ -106,12 +101,10 @@ class SlackNotificationsUponCheckinTest extends TestCase
{ {
$this->settings->disableSlackWebhook(); $this->settings->disableSlackWebhook();
event(new CheckoutableCheckedIn( $this->fireCheckInEvent(
Asset::factory()->laptopMbp()->create(), Asset::factory()->laptopMbp()->create(),
$checkoutTarget(), $checkoutTarget(),
User::factory()->superuser()->create(), );
''
));
Notification::assertNotSentTo(new AnonymousNotifiable, CheckinAssetNotification::class); Notification::assertNotSentTo(new AnonymousNotifiable, CheckinAssetNotification::class);
} }
@ -120,12 +113,10 @@ class SlackNotificationsUponCheckinTest extends TestCase
{ {
$this->settings->enableSlackWebhook(); $this->settings->enableSlackWebhook();
event(new CheckoutableCheckedIn( $this->fireCheckInEvent(
Component::factory()->ramCrucial8()->create(), Component::factory()->ramCrucial8()->create(),
Asset::factory()->laptopMbp()->create(), Asset::factory()->laptopMbp()->create(),
User::factory()->superuser()->create(), );
''
));
Notification::assertNothingSent(); Notification::assertNothingSent();
} }
@ -145,12 +136,10 @@ class SlackNotificationsUponCheckinTest extends TestCase
{ {
$this->settings->enableSlackWebhook(); $this->settings->enableSlackWebhook();
event(new CheckoutableCheckedIn( $this->fireCheckInEvent(
LicenseSeat::factory()->create(), LicenseSeat::factory()->create(),
$checkoutTarget(), $checkoutTarget(),
User::factory()->superuser()->create(), );
''
));
Notification::assertSentTo( Notification::assertSentTo(
new AnonymousNotifiable, new AnonymousNotifiable,
@ -166,13 +155,21 @@ class SlackNotificationsUponCheckinTest extends TestCase
{ {
$this->settings->disableSlackWebhook(); $this->settings->disableSlackWebhook();
event(new CheckoutableCheckedIn( $this->fireCheckInEvent(
LicenseSeat::factory()->create(), LicenseSeat::factory()->create(),
$checkoutTarget(), $checkoutTarget(),
User::factory()->superuser()->create(), );
''
));
Notification::assertNotSentTo(new AnonymousNotifiable, CheckinLicenseSeatNotification::class); Notification::assertNotSentTo(new AnonymousNotifiable, CheckinLicenseSeatNotification::class);
} }
private function fireCheckInEvent(Model $checkoutable, Model $target)
{
event(new CheckoutableCheckedIn(
$checkoutable,
$target,
User::factory()->superuser()->create(),
''
));
}
} }