DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2024-12-25 21:54:14 -08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Improve variable names and add comment

Browse source
This commit is contained in:
Marcus Moore 2024-04-11 16:44:13 -07:00
parent da03cfdbe5
commit c3a71cc182
No known key found for this signature in database
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
app/View/Label.php
View file

@ -142,28 +142,29 @@ class Label implements View
// Remove Duplicates // Remove Duplicates
$toAdd = $field $toAdd = $field
->filter(fn($o) => !$myFields->contains('dataSource', $o['dataSource'])) ->filter(fn($o) => !$myFields->contains('dataSource', $o['dataSource']))
->reduce(function ($carry, $item) { ->reduce(function ($previous, $current) {
// On the first iteration we simply return the item. // On the first iteration we simply return the item.
// If there is only one item to be processed for the row // If there is only one item to be processed for the row
// then this effectively skips everything below this if block. // then this effectively skips everything below this if block.
if (is_null($carry)){ if (is_null($previous)) {
return $item; return $current;
} }
// At this point we are dealing with a row with multiple items being displayed. // At this point we are dealing with a row with multiple items being displayed.
// We need to combine the label and value of the current item with the previous item.
// The end result of this will be in this format: // The end result of this will be in this format:
// {labelOne} {valueOne} | {labelTwo} {valueTwo} | {labelThree} {valueThree} // {labelOne} {valueOne} | {labelTwo} {valueTwo} | {labelThree} {valueThree}
$carry['value'] = trim(implode(' | ', [ $previous['value'] = trim(implode(' | ', [
implode(' ', [$carry['label'], $carry['value']]), implode(' ', [$previous['label'], $previous['value']]),
implode(' ', [$item['label'], $item['value']]), implode(' ', [$current['label'], $current['value']]),
])); ]));
// We'll set the label to an empty string since we // We'll set the label to an empty string since we
// injected the label into the value field above. // injected the label into the value field above.
$carry['label'] = ''; $previous['label'] = '';
return $carry; return $previous;
}); });
return $toAdd ? $myFields->push($toAdd) : $myFields; return $toAdd ? $myFields->push($toAdd) : $myFields;