From f7b483358ff114b56c753ee9c2964059a55a3bd2 Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 15 Nov 2021 20:32:59 -0800 Subject: [PATCH 01/39] Escape custom field values in API response Signed-off-by: snipe --- app/Http/Transformers/AssetsTransformer.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/Http/Transformers/AssetsTransformer.php b/app/Http/Transformers/AssetsTransformer.php index c323241cf0..0da314002f 100644 --- a/app/Http/Transformers/AssetsTransformer.php +++ b/app/Http/Transformers/AssetsTransformer.php @@ -93,15 +93,15 @@ class AssetsTransformer $value = (Gate::allows('superadmin')) ? $decrypted : strtoupper(trans('admin/custom_fields/general.encrypted')); $fields_array[$field->name] = [ - 'field' => $field->convertUnicodeDbSlug(), - 'value' => $value, + 'field' => e($field->convertUnicodeDbSlug()), + 'value' => e($value), 'field_format' => $field->format, ]; } else { $fields_array[$field->name] = [ - 'field' => $field->convertUnicodeDbSlug(), - 'value' => $asset->{$field->convertUnicodeDbSlug()}, + 'field' => e($field->convertUnicodeDbSlug()), + 'value' => e($asset->{$field->convertUnicodeDbSlug()}), 'field_format' => $field->format, ]; @@ -134,7 +134,7 @@ class AssetsTransformer 'id' => $component->id, 'pivot_id' => $component->pivot->id, - 'name' => $component->name, + 'name' => e($component->name), 'qty' => $component->pivot->assigned_qty, 'price_cost' => $component->purchase_cost, 'purchase_total' => $component->purchase_cost * $component->pivot->assigned_qty, From 78809c0fe7a6d9a74dbfb20b7aad2d2ebff0d12d Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 16 Nov 2021 12:02:45 -0800 Subject: [PATCH 02/39] Bumped version Signed-off-by: snipe --- config/version.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/config/version.php b/config/version.php index 6d1935fcf6..20cb685485 100644 --- a/config/version.php +++ b/config/version.php @@ -1,10 +1,10 @@ 'v5.3.1', - 'full_app_version' => 'v5.3.1 - build 6490-g6690a0f1d', - 'build_version' => '6490', + 'app_version' => 'v5.3.2', + 'full_app_version' => 'v5.3.2 - build 6508-g7ce5993f5', + 'build_version' => '6508', 'prerelease_version' => '', - 'hash_version' => 'g6690a0f1d', - 'full_hash' => 'v5.3.1-19-g6690a0f1d', + 'hash_version' => 'g7ce5993f5', + 'full_hash' => 'v5.3.2-15-g7ce5993f5', 'branch' => 'master', ); \ No newline at end of file From 5fb05d8b1c61bfcd63384d479e2d0aabfe3547fb Mon Sep 17 00:00:00 2001 From: Brady Wetherington Date: Wed, 17 Nov 2021 15:29:51 -0800 Subject: [PATCH 03/39] Change the `[END]` directive in `.htaccess` to `[L]` This allows backwards-compatibility with older Apache versions (which we _used_ to have), and should do the exact same thing. --- public/.htaccess | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/.htaccess b/public/.htaccess index ac2a6fa8e8..a9fec62ba5 100644 --- a/public/.htaccess +++ b/public/.htaccess @@ -6,7 +6,7 @@ RewriteEngine On # Needed for https://letsencrypt.org/ certificates. - RewriteRule ^\.well-known/acme-challenge/ - [END] + RewriteRule ^\.well-known/acme-challenge/ - [L] # Uncomment these two lines to force SSL redirect in Apache # RewriteCond %{HTTPS} off From a85fa14f9c9e0dd2aa2c2692f0fd4854769960f5 Mon Sep 17 00:00:00 2001 From: "Klaus J. Mueller" Date: Mon, 22 Nov 2021 17:58:26 +0100 Subject: [PATCH 04/39] fix #10344 and #9135 --- .../views/partials/bootstrap-table.blade.php | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/resources/views/partials/bootstrap-table.blade.php b/resources/views/partials/bootstrap-table.blade.php index 130bc9c2d3..7bbef128cf 100644 --- a/resources/views/partials/bootstrap-table.blade.php +++ b/resources/views/partials/bootstrap-table.blade.php @@ -145,7 +145,7 @@ function genericRowLinkFormatter(destination) { return function (value,row) { if (value) { - return ' ' + value + ''; + return '' + value + ''; } }; } @@ -196,7 +196,7 @@ var dpolymorphicItemFormatterest = 'fields/'; } - return ' ' + value.name + ''; + return '' + value.name + ''; } }; } @@ -466,7 +466,7 @@ if (value) { var groups = ''; for (var index in value.rows) { - groups += ' ' + value.rows[index].name + ' '; + groups += '' + value.rows[index].name + ' '; } return groups; } @@ -495,20 +495,20 @@ function deployedLocationFormatter(row, value) { if ((row) && (row!=undefined)) { - return ' ' + row.name + ''; + return '' + row.name + ''; } else if (value.rtd_location) { - return ' ' + value.rtd_location.name + ''; + return '' + value.rtd_location.name + ''; } } function groupsAdminLinkFormatter(value, row) { - return ' ' + value + ''; + return '' + value + ''; } function assetTagLinkFormatter(value, row) { if ((row.asset) && (row.asset.id)) { - return ' ' + row.asset.asset_tag + ''; + return '' + row.asset.asset_tag + ''; } return ''; @@ -516,14 +516,14 @@ function departmentNameLinkFormatter(value, row) { if ((row.assigned_user) && (row.assigned_user.department) && (row.assigned_user.department.name)) { - return ' ' + row.assigned_user.department.name + ''; + return '' + row.assigned_user.department.name + ''; } } function assetNameLinkFormatter(value, row) { if ((row.asset) && (row.asset.name)) { - return ' ' + row.asset.name + ''; + return '' + row.asset.name + ''; } } @@ -550,31 +550,31 @@ function emailFormatter(value) { if (value) { - return ' ' + value + ''; + return '' + value + ''; } } function linkFormatter(value) { if (value) { - return ' ' + value + ''; + return '' + value + ''; } } function assetCompanyFilterFormatter(value, row) { if (value) { - return ' ' + value + ''; + return '' + value + ''; } } function assetCompanyObjFilterFormatter(value, row) { if ((row) && (row.company)) { - return ' ' + row.company.name + ''; + return '' + row.company.name + ''; } } function usersCompanyObjFilterFormatter(value, row) { if (value) { - return ' ' + value + ''; + return '' + value + ''; } else { return value; } @@ -583,13 +583,13 @@ function employeeNumFormatter(value, row) { if ((row) && (row.assigned_to) && ((row.assigned_to.employee_number))) { - return ' ' + row.assigned_to.employee_number + ''; + return '' + row.assigned_to.employee_number + ''; } } function orderNumberObjFilterFormatter(value, row) { if (value) { - return ' ' + row.order_number + ''; + return '' + row.order_number + ''; } } From 1ca770895aba7f318399391eb499cd5508651182 Mon Sep 17 00:00:00 2001 From: Ivan Nieto Vivanco Date: Mon, 22 Nov 2021 18:43:21 -0600 Subject: [PATCH 05/39] Apply trim() function when storing Custom Fields names --- app/Http/Controllers/CustomFieldsController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/CustomFieldsController.php b/app/Http/Controllers/CustomFieldsController.php index a8be424841..04819a9b0f 100644 --- a/app/Http/Controllers/CustomFieldsController.php +++ b/app/Http/Controllers/CustomFieldsController.php @@ -92,7 +92,7 @@ class CustomFieldsController extends Controller $this->authorize('create', CustomField::class); $field = new CustomField([ - "name" => $request->get("name"), + "name" => trim($request->get("name")), "element" => $request->get("element"), "help_text" => $request->get("help_text"), "field_values" => $request->get("field_values"), @@ -212,7 +212,7 @@ class CustomFieldsController extends Controller $this->authorize('update', $field); - $field->name = e($request->get("name")); + $field->name = trim(e($request->get("name"))); $field->element = e($request->get("element")); $field->field_values = e($request->get("field_values")); $field->user_id = Auth::id(); From ab06c265271f1d02fadf96299c1047a296c1962d Mon Sep 17 00:00:00 2001 From: Adam Date: Tue, 23 Nov 2021 16:13:38 +0000 Subject: [PATCH 06/39] Rocky Linux Support Addition to enable Rocky Linux installation. --- snipeit.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/snipeit.sh b/snipeit.sh index e94cfe018a..20700463c9 100755 --- a/snipeit.sh +++ b/snipeit.sh @@ -301,7 +301,7 @@ echo ' ' echo "" -echo " Welcome to Snipe-IT Inventory Installer for CentOS, Fedora, Debian and Ubuntu!" +echo " Welcome to Snipe-IT Inventory Installer for CentOS, Rocky, Fedora, Debian and Ubuntu!" echo "" shopt -s nocasematch case $distro in @@ -323,7 +323,7 @@ case $distro in apache_group=www-data apachefile=/etc/apache2/sites-available/$APP_NAME.conf ;; - *centos*|*redhat*|*ol*|*rhel*) + *centos*|*redhat*|*ol*|*rhel*|*rocky*) echo " The installer has detected $distro version $version." distro=centos apache_group=apache From d95d3dc2829d19d0685493cbdc134d9355e5fd1f Mon Sep 17 00:00:00 2001 From: Ivan Nieto Vivanco Date: Tue, 23 Nov 2021 17:21:46 -0600 Subject: [PATCH 07/39] Add the call to defaultValue() function in custom fields with date format --- resources/views/models/custom_fields_form.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/views/models/custom_fields_form.blade.php b/resources/views/models/custom_fields_form.blade.php index f70d8fba2a..f434238f51 100644 --- a/resources/views/models/custom_fields_form.blade.php +++ b/resources/views/models/custom_fields_form.blade.php @@ -48,7 +48,7 @@
- +
From 55d05eeae31df0f9ab39f9889068fe26a4c723f6 Mon Sep 17 00:00:00 2001 From: Shao Yu-Lung Date: Wed, 24 Nov 2021 10:28:10 +0800 Subject: [PATCH 08/39] fix modal-title html tag unpaired. --- resources/views/categories/edit.blade.php | 2 +- resources/views/layouts/default.blade.php | 2 +- resources/views/modals/category.blade.php | 2 +- resources/views/modals/kit-accessory.blade.php | 2 +- resources/views/modals/kit-consumable.blade.php | 2 +- resources/views/modals/kit-license.blade.php | 2 +- resources/views/modals/kit-model.blade.php | 2 +- resources/views/modals/location.blade.php | 2 +- resources/views/modals/manufacturer.blade.php | 2 +- resources/views/modals/model.blade.php | 2 +- resources/views/modals/statuslabel.blade.php | 2 +- resources/views/modals/supplier.blade.php | 2 +- resources/views/modals/upload-file.blade.php | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/resources/views/categories/edit.blade.php b/resources/views/categories/edit.blade.php index 75d8457c97..af90a0cd7e 100755 --- a/resources/views/categories/edit.blade.php +++ b/resources/views/categories/edit.blade.php @@ -108,7 +108,7 @@