DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-01-11 22:07:29 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add test validation test for update method and remove name uniqueness constraint

Browse source
This commit is contained in:
Marcus Moore 2024-11-07 11:02:10 -08:00
parent 8873137ed0
commit c5710b858e
No known key found for this signature in database
3 changed files with 20 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/Http/Controllers/ReportTemplatesController.php
View file

@ -15,10 +15,10 @@ class ReportTemplatesController extends Controller
$this->authorize('reports.view');
// Ignore "options" rules since data does not come in under that key...
$request->validate(Arr::except((new ReportTemplate)->getRules(), 'options'));
$validated = $request->validate(Arr::except((new ReportTemplate)->getRules(), 'options'));
$report = $request->user()->reportTemplates()->create([
'name' => $request->get('name'),
'name' => $validated['name'],
'options' => $request->except(['_token', 'name']),
]);
@ -55,9 +55,10 @@ class ReportTemplatesController extends Controller
{
$this->authorize('reports.view');
// @todo: validation
// Ignore "options" rules since data does not come in under that key...
$validated = $request->validate(Arr::except((new ReportTemplate)->getRules(), 'options'));
$reportTemplate->name = $request->input('name');
$reportTemplate->name = $validated['name'];
$reportTemplate->options = $request->except(['_token', 'name']);
$reportTemplate->save();

3
app/Models/ReportTemplate.php
View file

@ -24,11 +24,8 @@ class ReportTemplate extends Model
];
protected $rules = [
// @todo: this should probably be unique for each user so people don't get errors trying to use a name someone else already used...
// @todo: but enabling shared reports in the future would mean we would have name collisions then...
'name' => [
'required',
'unique:report_templates,name',
],
'options' => [
'required',

15
tests/Feature/ReportTemplates/UpdateReportTemplateTest.php
View file

@ -25,6 +25,21 @@ class UpdateReportTemplateTest extends TestCase implements TestsPermissionsRequi
->assertNotFound();
}
public function testUpdatingReportTemplateRequiresValidFields()
{
$user = User::factory()->canViewReports()->create();
$reportTemplate = ReportTemplate::factory()->for($user, 'creator')->create();
$this->actingAs($user)
->post($this->getRoute($reportTemplate), [
//
])
->assertSessionHasErrors([
'name' => 'The name field is required.',
]);
}
public function testCanUpdateAReportTemplate()
{
$user = User::factory()->canViewReports()->create();