Merge pull request #10103 from snipe/fixes/make_boolean_fields_nullable

Fixed issue when creating a status label via API - default_label and show_in_nav being not nullable

app/Http/Controllers/Api/StatuslabelsController.php

@@ -74,7 +74,7 @@ class StatuslabelsController extends Controller
         $statuslabel->archived = $statusType['archived'];
         $statuslabel->color             =  $request->input('color');
         $statuslabel->show_in_nav       =  $request->input('show_in_nav', 0);
-        $statuslabel->default_label     =  $request->input('default_label');
+        $statuslabel->default_label     =  $request->input('default_label', 0);
 
 
         if ($statuslabel->save()) {
@@ -127,8 +127,8 @@ class StatuslabelsController extends Controller
         $statuslabel->pending = $statusType['pending'];
         $statuslabel->archived = $statusType['archived'];
         $statuslabel->color             =  $request->input('color');
-        $statuslabel->show_in_nav       =  $request->input('show_in_nav');
+        $statuslabel->show_in_nav       =  $request->input('show_in_nav', 0);
-        $statuslabel->default_label     =  $request->input('default_label');
+        $statuslabel->default_label     =  $request->input('default_label', 0);
 
         if ($statuslabel->save()) {
             return response()->json(Helper::formatStandardApiResponse('success', $statuslabel, trans('admin/statuslabels/message.update.success')));

database/migrations/2016_08_23_145619_add_show_in_nav_to_status_labels.php

@@ -13,7 +13,7 @@ class AddShowInNavToStatusLabels extends Migration
     public function up()
     {
         Schema::table('status_labels', function (Blueprint $table) {
-            $table->boolean('show_in_nav')->default(0);
+            $table->boolean('show_in_nav')->nullable()->default(0);
         });
     }
 

database/migrations/2018_03_06_054937_add_default_flag_on_statuslabels.php

@@ -14,7 +14,7 @@ class AddDefaultFlagOnStatuslabels extends Migration
     public function up()
     {
         Schema::table('status_labels', function (Blueprint $table) {
-            $table->boolean('default_label')->default(0);
+            $table->boolean('default_label')->nullable()->default(0);
         });
     }
 

database/migrations/2021_09_20_183216_change_default_label_to_nullable.php

@@ -0,0 +1,46 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
+use App\Models\Statuslabel;
+
+class ChangeDefaultLabelToNullable extends Migration
+{
+    /**
+     * Run the migrations.
+     * 
+     * This is stupid because it has a default valuye of 0 so it *should* 
+     * default to 0, but it doesn't on some versions of MySQL. 
+     *
+     * @return void
+     */
+    public function up()
+    {
+
+
+        Statuslabel::whereNull('default_label')
+        ->update(['default_label' => 0]);
+
+        Statuslabel::whereNull('show_in_nav')
+        ->update(['show_in_nav' => 0]);
+
+
+        Schema::table('status_labels', function (Blueprint $table) {
+            $table->boolean('default_label')->nullable()->default(0)->change();
+            $table->boolean('show_in_nav')->nullable()->default(0)->change();
+        });
+
+
+    }
+
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        //
+    }
+}