DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2024-10-02 13:47:41 -07:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

fix: add more checks at Depreciable.php

Browse source
This commit is contained in:
Minaev Dmitriy 2018-08-25 19:17:48 +03:00
parent 7b70afa2a1
commit daba90b346
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
app/Models/Depreciable.php
View file

@ -42,6 +42,13 @@ class Depreciable extends SnipeModel
public function getDepreciatedValue() public function getDepreciatedValue()
{ {
if (!$this->get_depreciation()) { // will never happen
return $this->purchase_cost;
}
if ($this->get_depreciation()->months <= 0) {
return $this->purchase_cost;
}
$depreciation = 0; $depreciation = 0;
$setting = Setting::first(); $setting = Setting::first();
switch($setting->depreciation_method) { switch($setting->depreciation_method) {
@ -66,14 +73,6 @@ class Depreciable extends SnipeModel
public function getLinearDepreciatedValue() public function getLinearDepreciatedValue()
{ {
if (!$this->get_depreciation()) { // will never happen
return $this->purchase_cost;
}
if ($this->get_depreciation()->months <= 0) {
return $this->purchase_cost;
}
// fraction of value left // fraction of value left
$months_remaining = $this->time_until_depreciated()->m + 12*$this->time_until_depreciated()->y; //UGlY $months_remaining = $this->time_until_depreciated()->m + 12*$this->time_until_depreciated()->y; //UGlY
$current_value = round(($months_remaining/ $this->get_depreciation()->months) * $this->purchase_cost, 2); $current_value = round(($months_remaining/ $this->get_depreciation()->months) * $this->purchase_cost, 2);