DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-01-12 06:17:28 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Use filled instead of has. (#6033)

Browse source 
I think this merged in a weird order and was missed by the global
find/replace.  This fixes bulkassets/bulkusers editing.

At some point we should look at refactoring BulkAssetsController@edit to
only run one DB query, rather than one per item.
This commit is contained in:
Daniel Meltzer 2018-08-02 12:54:19 -04:00 committed by snipe
parent 2637ce56a1
commit e368a20427
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/Http/Controllers/Assets/BulkAssetsController.php
View file

@ -141,7 +141,7 @@ class BulkAssetsController extends Controller
*/ */
protected function conditionallyAddItem($field) protected function conditionallyAddItem($field)
{ {
if(request()->has($field)) { if(request()->filled($field)) {
$this->update_array[$field] = request()->input($field); $this->update_array[$field] = request()->input($field);
} }
return $this; return $this;

2
app/Http/Controllers/Users/BulkUsersController.php
View file

@ -142,7 +142,7 @@ class BulkUsersController extends Controller
*/ */
protected function conditionallyAddItem($field) protected function conditionallyAddItem($field)
{ {
if(request()->has($field)) { if(request()->filled($field)) {
$this->update_array[$field] = request()->input($field); $this->update_array[$field] = request()->input($field);
} }
return $this; return $this;