DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-03-05 20:52:15 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

test added, permission fixed

Browse source
This commit is contained in:
spencerrlongg 2024-07-23 14:29:17 -05:00
parent b9fdb5880a
commit e8864ffb01
2 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/Http/Requests/UpdateAssetRequest.php
View file

@ -15,7 +15,7 @@ class UpdateAssetRequest extends ImageUploadRequest
*/ */
public function authorize() public function authorize()
{ {
return Gate::allows('update', new Asset); return Gate::allows('update', $this->asset);
} }
/** /**

13
tests/Feature/Assets/Api/UpdateAssetTest.php
View file

@ -427,16 +427,14 @@ class UpdateAssetTest extends TestCase
public function testAssetCannotBeUpdatedByUserInSeparateCompany() public function testAssetCannotBeUpdatedByUserInSeparateCompany()
{ {
$this->markTestIncomplete('not done with this yet');
$this->settings->enableMultipleFullCompanySupport(); $this->settings->enableMultipleFullCompanySupport();
$companyA = Company::factory()->create(); $companyA = Company::factory()->create();
$companyB = Company::factory()->create(); $companyB = Company::factory()->create();
$userA = User::factory()->create([ $userA = User::factory()->editAssets()->create([
'company_id' => $companyA->id, 'company_id' => $companyA->id,
]); ]);
$userB = User::factory()->create([ $userB = User::factory()->editAssets()->create([
'company_id' => $companyB->id, 'company_id' => $companyB->id,
]); ]);
$asset = Asset::factory()->create([ $asset = Asset::factory()->create([
@ -448,7 +446,12 @@ class UpdateAssetTest extends TestCase
->patchJson(route('api.assets.update', $asset->id), [ ->patchJson(route('api.assets.update', $asset->id), [
'name' => 'test name' 'name' => 'test name'
]) ])
->assertStatus(403); ->assertStatusMessageIs('error');
$this->actingAsForApi($userA)
->patchJson(route('api.assets.update', $asset->id), [
'name' => 'test name'
])
->assertStatusMessageIs('success');
} }
} }