From 4edaba648eb6145637dfd92094940788b4d5e539 Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Tue, 26 Sep 2017 13:05:34 -0700
Subject: [PATCH 1/4] Tweaks to upgrade script

---
 upgrade.php | 48 ++++++++++++++++++++++++++++++++++++------------
 1 file changed, 36 insertions(+), 12 deletions(-)

diff --git a/upgrade.php b/upgrade.php
index 6940f483d4..42c4735cfb 100644
--- a/upgrade.php
+++ b/upgrade.php
@@ -1,23 +1,29 @@
 <?php
 (PHP_SAPI !== 'cli' || isset($_SERVER['HTTP_USER_AGENT'])) && die('Access denied.');
 
-
 echo "Welcome to the Snipe-IT upgrader.\n\n";
+echo "Please note that this script will not download the latest Snipe-IT \n";
+echo "files for you, it simply runs the standard composer and artisan \n";
+echo "commands needed to finalize the upgrade after \n\n";
 
-echo "If you have any encrypted custom fields, BE SURE TO run the recrypter. See the Snipe-IT documentation for help.\n\n";
+echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! WARNING !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n";
+echo "!! If you have any encrypted custom fields, BE SURE TO run the recrypter. \n";
+echo "!! See the Snipe-IT documentation for help: \n";
+echo "!! https://snipe-it.readme.io/docs/upgrading-to-v4\n";
+echo "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! WARNING !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n";
 
 echo "--------------------------------------------------------\n";
 echo "STEP 1: Backing up database: \n";
 echo "--------------------------------------------------------\n\n";
 $backup = shell_exec('php artisan snipeit:backup');
-echo '- '.$backup."\n\n";
+echo '-- '.$backup."\n\n";
 
 
 echo "--------------------------------------------------------\n";
 echo "STEP 2: Putting application into maintenance mode: \n";
 echo "--------------------------------------------------------\n\n";
 $down = shell_exec('php artisan down');
-echo '- '.$down."\n\n";
+echo '-- '.$down."\n\n";
 
 echo "--------------------------------------------------------\n";
 echo "Step 3: Cleaning up old cached files:\n";
@@ -47,9 +53,12 @@ if (file_exists('bootstrap/cache/config.php')) {
 
 $config_clear = shell_exec('php artisan config:clear');
 $cache_clear = shell_exec('php artisan cache:clear');
-echo '- '.$config_clear;
-echo '- '.$cache_clear;
-
+$route_clear = shell_exec('php artisan route:clear');
+$view_clear = shell_exec('php artisan view:clear');
+echo '-- '.$config_clear;
+echo '-- '.$cache_clear;
+echo '-- '.$route_clear;
+echo '-- '.$view_clear;
 echo "\n";
 
 echo "--------------------------------------------------------\n";
@@ -60,13 +69,17 @@ echo "--------------------------------------------------------\n\n";
 
 // Composer install
 if (file_exists('composer.phar')) {
-    echo "- Local composer.phar detected, so we'll use that.\n\n";
+    echo "-- Local composer.phar detected, so we'll use that.\n\n";
+    $composer_dump = shell_exec('php composer.phar dump');
     $composer = shell_exec('php composer.phar install --prefer-source');
+
 } else {
-    echo "- We couldn't find a local composer.phar - trying globally.\n\n";
+    echo "-- We couldn't find a local composer.phar - trying globally.\n\n";
+    $composer_dump = shell_exec('composer dump');
     $composer = shell_exec('composer install --prefer-source');
 }
 
+echo $composer_dump."\n\n";
 echo $composer."\n\n";
 
 
@@ -75,7 +88,7 @@ echo "Step 5: Migrating database:\n";
 echo "--------------------------------------------------------\n\n";
 
 $migrations = shell_exec('php artisan migrate --force');
-echo '- '.$migrations."\n\n";
+echo '-- '.$migrations."\n\n";
 
 
 echo "--------------------------------------------------------\n";
@@ -93,11 +106,22 @@ if ((!file_exists('storage/oauth-public.key')) || (!file_exists('storage/oauth-p
 
 
 echo "--------------------------------------------------------\n";
-echo "Step 7: Taking application out of maintenance mode:\n";
+echo "Step 7: Caching routes and config:\n";
+echo "--------------------------------------------------------\n\n";
+$config_cache = shell_exec('php artisan config:cache');
+$route_cache = shell_exec('php artisan route:cache');
+echo '-- '.$config_cache;
+echo '-- '.$route_cache;
+echo "\n";
+
+
+
+echo "--------------------------------------------------------\n";
+echo "Step 8: Taking application out of maintenance mode:\n";
 echo "--------------------------------------------------------\n\n";
 
 $up = shell_exec('php artisan up');
-echo '- '.$up."\n\n";
+echo '-- '.$up."\n\n";
 
 echo "--------------------------------------------------------\n";
 echo "FINISHED! Clear your browser cookies and re-login to use :\n";

From d585a34a268829abfc6da95aacb73fd9d529ab5c Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Tue, 26 Sep 2017 13:11:01 -0700
Subject: [PATCH 2/4] Prevent users from running this as root/admin user

---
 upgrade.php | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/upgrade.php b/upgrade.php
index 42c4735cfb..368bbeccd5 100644
--- a/upgrade.php
+++ b/upgrade.php
@@ -1,6 +1,13 @@
 <?php
 (PHP_SAPI !== 'cli' || isset($_SERVER['HTTP_USER_AGENT'])) && die('Access denied.');
 
+$pwu_data = posix_getpwuid(posix_geteuid());
+$username = $pwu_data['name'];
+
+if (($username=='root') || ($username=='admin')) {
+    die("\nERROR: This script should not be run as root/admin. Exiting.\n\n");
+}
+
 echo "Welcome to the Snipe-IT upgrader.\n\n";
 echo "Please note that this script will not download the latest Snipe-IT \n";
 echo "files for you, it simply runs the standard composer and artisan \n";

From e27e1a78c35eb308d965c6ad99518a5406a8372d Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Tue, 26 Sep 2017 16:01:23 -0700
Subject: [PATCH 3/4] Fix for case where a fieldset is assigned to a model, but
 no fields are assigned

---
 app/Http/Transformers/AssetsTransformer.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/Http/Transformers/AssetsTransformer.php b/app/Http/Transformers/AssetsTransformer.php
index 492e86a95b..c8c054c9be 100644
--- a/app/Http/Transformers/AssetsTransformer.php
+++ b/app/Http/Transformers/AssetsTransformer.php
@@ -75,8 +75,9 @@ class AssetsTransformer
         ];
 
 
-        if ($asset->model->fieldset) {
+        if (($asset->model->fieldset) && (count($asset->model->fieldset->fields)> 0)) {
             $fields_array = array();
+
             foreach ($asset->model->fieldset->fields as $field) {
 
                 if ($field->isFieldDecryptable($asset->{$field->convertUnicodeDbSlug()})) {

From 5e1df7049c44b192fecf189b022a506a20661aaf Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Tue, 26 Sep 2017 16:02:55 -0700
Subject: [PATCH 4/4] Make collation and charset for mysql an env variable

---
 .env.example        | 2 ++
 config/database.php | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/.env.example b/.env.example
index cd22ea38ea..9bc90e5ed2 100644
--- a/.env.example
+++ b/.env.example
@@ -19,6 +19,8 @@ DB_USERNAME=null
 DB_PASSWORD=null
 DB_PREFIX=null
 DB_DUMP_PATH='/usr/bin'
+DB_CHARSET=utf8mb4
+DB_COLLATION=utf8mb4_unicode_ci
 
 # --------------------------------------------
 # OPTIONAL: SSL DATABASE SETTINGS
diff --git a/config/database.php b/config/database.php
index 28a8c85be0..77c07f17f8 100755
--- a/config/database.php
+++ b/config/database.php
@@ -65,8 +65,8 @@ return [
             'database'  => env('DB_DATABASE', 'forge'),
             'username'  => env('DB_USERNAME', 'forge'),
             'password'  => env('DB_PASSWORD', ''),
-            'charset'   => 'utf8mb4',
-            'collation' => 'utf8mb4_unicode_ci',
+            'charset'   => env('DB_CHARSET', 'utf8mb4'),
+            'collation' => env('DB_COLLATION', 'utf8mb4_unicode_ci'),
             'prefix'    => env('DB_PREFIX', null),
             'strict'    => false,
             'engine'    => null,