DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-01-12 06:17:28 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #10279 from snipe/fixes/turn_get_into_post_for_custom_field_required

Browse source 
Turn custom fields required/optional/remove into POST requests
This commit is contained in:
snipe 2021-11-08 14:37:36 -08:00 committed by GitHub
parent 16d18bc7eb 0d811d067c
commit edf98cb795
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
resources/views/custom_fields/fieldsets/view.blade.php
View file

@ -57,21 +57,28 @@
<td>{{$field->element}}</td> <td>{{$field->element}}</td>
<td>{{ $field->field_encrypted=='1' ? trans('general.yes') : trans('general.no') }}</td> <td>{{ $field->field_encrypted=='1' ? trans('general.yes') : trans('general.no') }}</td>
<td> <td>
@if ($field->pivot->required) @if ($field->pivot->required)
<a href="{{ route('fields.optional', [$custom_fieldset->id, $field->id]) }}"> <form method="post" action="{{ route('fields.optional', [$custom_fieldset->id, $field->id]) }}">
<i class="fa fa-check text-success" aria-hidden="true"></i> @csrf
<span class="sr-only">Required - click to make optional</span> <button type="submit" class="btn btn-link"><i class="fa fa-check text-success" aria-hidden="true"></i></button>
</a> </form>
@else @else
<a href="{{ route('fields.required', [$custom_fieldset->id, $field->id]) }}">
<i class="fa fa-times text-danger" aria-hidden="true"></i> <form method="post" action="{{ route('fields.required', [$custom_fieldset->id, $field->id]) }}">
<span class="sr-only">Optional - click to make required</span> @csrf
</a> <button type="submit" class="btn btn-link"><i class="fa fa-times text-danger" aria-hidden="true"></i></button>
</form>
@endif @endif
</td> </td>
<td> <td>
@can('update', $custom_fieldset) @can('update', $custom_fieldset)
<a href="{{ route('fields.disassociate', [$field, $custom_fieldset->id]) }}" class="btn btn-sm btn-danger">Remove</a> <form method="post" action="{{ route('fields.disassociate', [$field, $custom_fieldset->id]) }}">
@csrf
<button type="submit" class="btn btn-sm btn-danger">Remove</button>
</form>
@endcan @endcan
</td> </td>
</tr> </tr>

6
routes/web/fields.php
View file

@ -7,17 +7,17 @@
Route::group([ 'prefix' => 'fields','middleware' => ['auth'] ], function () { Route::group([ 'prefix' => 'fields','middleware' => ['auth'] ], function () {
Route::get('required/{fieldset_id}/{field_id}', Route::post('required/{fieldset_id}/{field_id}',
['uses' => 'CustomFieldsetsController@makeFieldRequired', ['uses' => 'CustomFieldsetsController@makeFieldRequired',
'as' => 'fields.required'] 'as' => 'fields.required']
); );
Route::get('optional/{fieldset_id}/{field_id}', Route::post('optional/{fieldset_id}/{field_id}',
['uses' => 'CustomFieldsetsController@makeFieldOptional', ['uses' => 'CustomFieldsetsController@makeFieldOptional',
'as' => 'fields.optional'] 'as' => 'fields.optional']
); );
Route::get('{field_id}/fieldset/{fieldset_id}/disassociate', Route::post('{field_id}/fieldset/{fieldset_id}/disassociate',
['uses' => 'CustomFieldsController@deleteFieldFromFieldset', ['uses' => 'CustomFieldsController@deleteFieldFromFieldset',
'as' => 'fields.disassociate'] 'as' => 'fields.disassociate']
); );