diff --git a/app/Console/Commands/CheckoutLicenseToAllUsers.php b/app/Console/Commands/CheckoutLicenseToAllUsers.php index fab2b318c6..d655b5aceb 100644 --- a/app/Console/Commands/CheckoutLicenseToAllUsers.php +++ b/app/Console/Commands/CheckoutLicenseToAllUsers.php @@ -22,7 +22,7 @@ class CheckoutLicenseToAllUsers extends Command * * @var string */ - protected $description = 'Command description'; + protected $description = 'Checks out licenses to all users'; /** * Create a new command instance. diff --git a/app/Http/Transformers/ActionlogsTransformer.php b/app/Http/Transformers/ActionlogsTransformer.php index 602fc6400f..c58760d4de 100644 --- a/app/Http/Transformers/ActionlogsTransformer.php +++ b/app/Http/Transformers/ActionlogsTransformer.php @@ -85,6 +85,7 @@ class ActionlogsTransformer 'id' => (int) $actionlog->item->id, 'name' => ($actionlog->itemType()=='user') ? e($actionlog->item->getFullNameAttribute()) : e($actionlog->item->getDisplayNameAttribute()), 'type' => e($actionlog->itemType()), + 'serial' =>e($actionlog->item->serial) ? e($actionlog->item->serial) : null ] : null, 'location' => ($actionlog->location) ? [ 'id' => (int) $actionlog->location->id, diff --git a/app/Models/CustomField.php b/app/Models/CustomField.php index e94b3fcc2f..e0b06318bb 100644 --- a/app/Models/CustomField.php +++ b/app/Models/CustomField.php @@ -48,7 +48,11 @@ class CustomField extends Model * * @var array */ - protected $rules = []; + protected $rules = [ + 'name' => 'required|unique:custom_fields', + 'element' => 'required|in:text,listbox,textarea,checkbox,radio', + 'field_encrypted' => 'nullable|boolean', + ]; /** * The attributes that are mass assignable. @@ -357,15 +361,9 @@ class CustomField extends Model public function validationRules($regex_format = null) { return [ - 'name' => 'required|unique:custom_fields', - 'element' => [ - 'required', - Rule::in(['text', 'listbox', 'textarea', 'checkbox', 'radio']), - ], 'format' => [ Rule::in(array_merge(array_keys(self::PREDEFINED_FORMATS), self::PREDEFINED_FORMATS, [$regex_format])), - ], - 'field_encrypted' => 'nullable|boolean', + ] ]; } diff --git a/resources/views/notifications/markdown/checkin-asset.blade.php b/resources/views/notifications/markdown/checkin-asset.blade.php index 947fed28c0..74a4381707 100644 --- a/resources/views/notifications/markdown/checkin-asset.blade.php +++ b/resources/views/notifications/markdown/checkin-asset.blade.php @@ -3,8 +3,8 @@ {{ trans('mail.the_following_item') }} -@if ($item->getImageUrl()) -
Asset
+@if (($snipeSettings->show_images_in_email =='1') && $item->getImageUrl()) +
Asset
@endif @component('mail::table') diff --git a/resources/views/reports/activity.blade.php b/resources/views/reports/activity.blade.php index 90a3ded452..0922bf6b06 100644 --- a/resources/views/reports/activity.blade.php +++ b/resources/views/reports/activity.blade.php @@ -49,6 +49,7 @@ {{ trans('general.action') }} {{ trans('general.file_name') }} {{ trans('general.type') }} + {{ trans('admin/hardware/table.serial') }} {{ trans('general.item') }} {{ trans('general.to') }} {{ trans('general.notes') }} diff --git a/resources/views/users/view.blade.php b/resources/views/users/view.blade.php index f210bb03e7..4455154499 100755 --- a/resources/views/users/view.blade.php +++ b/resources/views/users/view.blade.php @@ -935,7 +935,8 @@ @if ($snipeSettings->require_accept_signature=='1') {{ trans('general.signature') }} @endif - {{ trans('general.item') }} + {{ trans('admin/hardware/table.serial') }} + {{ trans('general.item') }} {{ trans('general.target') }}